[POC]Integrate a11y scan into E2E tests #2096
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR added E2E tests for a11y by using snapshot method provided by playwright. The reason we are using snapshots instead of excluding/ixcluding a11y rules are because current storefront still have known a11y errors which may be addressed in the future.
With snapshot method, we are capturing the current stage of a11y on each page on the E2E that we have in the project
Why
We want to make sure we are not introduce any a11y bugs into current existing code. Although we have fixed most of our a11y in GUS, but we still have some minor errors that have no plan to get fixed.
Using snapshot, we are capturing the current state of a11y on the storefront
Pros
Cons
Types of Changes
Changes
How to Test-Drive This PR
RETAIL_APP_HOME=http://localhost:3000 test:e2e
and make sure no tests are failing.Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization