@W-15953350 Reset Password #2132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunakim714
changed the title
…assword-poc-mc Signed-off-by: Yuna Kim <[email protected]>
…rceCommerceCloud/pwa-kit into W-15953350-reset-password-poc-mc
bredmond-sf
approved these changes
Dec 6, 2024
| `${slasClient.clientConfig.parameters.clientId}:${this.clientSecret}` | ||
| )}` | ||
| } | ||
| // TODO: no code verifier needed with the fix blair has made, delete this when the fix has been merged to production |
There was a problem hiding this comment.
Nope, this is to delete the @ts-ignore comment, as right now we get an error because we are not passing in code_verifier
yunakim714
reviewed
Dec 10, 2024
| const getPasswordResetToken = async (email) => { | ||
| await getPasswordResetTokenMutation.mutateAsync({ | ||
| user_id: email, | ||
| callback_uri: absoluteUrl('/reset-password-callback') |
There was a problem hiding this comment.
NOTE: If customers wanted to customize the callback URI they would have to come into this hook and change this line... Or should we have this configurable in the config file ?🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revamps the Reset Password flow in the PWA Kit to leverage the SLAS password reset process and Marketing Cloud integration to send the reset password magic link to the shopper.
Types of Changes
Changes
usePasswordReset()hook to the template app[email protected]How to Test-Drive This PR
[email protected]with a magic link, redirecting to the reset password formTo run tests:
template-retail-react-app: runnpm run test app/hooks/use-password-reset.test.jsChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization