Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing a file without java_package stopped to work in 1.4.0 #108

Open
davidlar opened this issue Mar 2, 2015 · 0 comments
Open

Importing a file without java_package stopped to work in 1.4.0 #108

davidlar opened this issue Mar 2, 2015 · 0 comments

Comments

@davidlar
Copy link

davidlar commented Mar 2, 2015

Example:

to-import.proto:

package to.import;

message ToImport {
  required int32 required_field = 1;
}

importer.proto

package importer;

import "to-import.proto";

message Importer {
  required ToImport required_field = 1;
}

This will now create a Importer.scala with a ToImport without package name, which won't compile.

Pull request #107 fixes this (hopefully).

Regards David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant