Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Update Snfoundry package to support starknet foundry script #394

Open
Nadai2010 opened this issue Dec 17, 2024 · 2 comments · May be fixed by #426
Open

[FEAT] Update Snfoundry package to support starknet foundry script #394

Nadai2010 opened this issue Dec 17, 2024 · 2 comments · May be fixed by #426
Assignees

Comments

@Nadai2010
Copy link
Collaborator

Issue Overview

Currently, our declare and deploy process relies on starknet.js (TypeScript). However, we aim to update the starknet-foundry branch to align with the latest toolchain versions and reevaluate the feasibility of porting this branch to main.

The most recent updates regarding this effort can be found in [this comment](#301 (comment)), which outlines the status at that time and the bugs that previously blocked the merge into main.


Proposed Solutions or Ideas

To modernize and stabilize the declare and deploy process, we propose migrating it from starknet.js to Cairo, utilizing sn-foundry/sncast_std. Specifically, the following updates and configurations are required:

  1. Toolchain Updates:

    • Use Scarb version 2.9.2.
    • Use starknet-devnet version 0.2.3.
    • Use the latest version of sn-foundry, preferably 0.34.0.
  2. Environment Testing:

    • Ensure the updated process works seamlessly on the Sepolia testnet.
  3. Backward Compatibility:

    • The proposed solution must not break existing features or functionalities of the framework.
  4. Documentation and Testing:

    • Document all changes made during the migration process.
    • Implement sufficient tests to validate the stability of the updated deployment pipeline.
@barretodavid
Copy link

What would be the advantage of using Cairo for the deployment script instead of Typescript?

@Nadai2010
Copy link
Collaborator Author

Hi @barretodavid, this FEAT is to keep updating the script with cairo, we keep it in a branch and update it every X time.

The times we have updated and tested it we don't see it feasible in the main. IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants