Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "fnm" an official installation method for Node.js on Windows #1357

Open
ovflowd opened this issue Dec 28, 2024 · 9 comments
Open

Make "fnm" an official installation method for Node.js on Windows #1357

ovflowd opened this issue Dec 28, 2024 · 9 comments

Comments

@ovflowd
Copy link

ovflowd commented Dec 28, 2024

Hi! I'm Claudio from the Node.js team, we recently published a new Downloads page https://nodejs.org/en/download and we'd like to onboard "fnm" as an official installation method. Here are the criteria we are defining of what marks an installation method as official (https://nodejs-org-git-feat-official-community-docs-openjs.vercel.app/en/about/previous-releases#official-versus-community)

How can we proceed with this? ✨

@ovflowd
Copy link
Author

ovflowd commented Dec 28, 2024

Here is a related PR on the Node-side of things nodejs/nodejs.org#7365

@ovflowd
Copy link
Author

ovflowd commented Dec 28, 2024

cc @Schniz

@Schniz
Copy link
Owner

Schniz commented Dec 29, 2024

Seems like fnm qualifies as official installer: it downloads binaries as is from Node.js distribution mirror (nodejs.org/dist by default). Zero manipulation happening there. What else should I do to make it happen?

@ovflowd
Copy link
Author

ovflowd commented Dec 29, 2024

One last question, so once a new release becomes available on Node side I assume it becomes available immediately on fnm side? I assume fnm probably reads our index.json or something like that? Haven't checked the source.

But yeah, that's it. And the fact that we might need to pint you from time to time for questions regarding fnm or issues that people open on our repositories. Pretty much just having a way to contact you through GitHub :)

@ovflowd
Copy link
Author

ovflowd commented Dec 29, 2024

(Also if you could check we implemented the snippets correctly, that'd be great!)

@shirshak55
Copy link

shirshak55 commented Dec 31, 2024

@ovflowd Yes. It uses index.json

Relevant source code here: https://github.com/Schniz/fnm/blob/master/src/remote_node_index.rs#L86

@ovflowd
Copy link
Author

ovflowd commented Jan 6, 2025

Then I assume we can proceed and make, fnm an official installation method. Do you feel comfortable with this, @Schniz?

@ovflowd
Copy link
Author

ovflowd commented Jan 16, 2025

Landed in nodejs/nodejs.org#7400

@shirshak55
Copy link

nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants