Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop reseeding each call to solve #464

Open
isaacsas opened this issue Nov 12, 2024 · 0 comments
Open

stop reseeding each call to solve #464

isaacsas opened this issue Nov 12, 2024 · 0 comments

Comments

@isaacsas
Copy link
Member

By default JumpProcesses reseeds with a rand(UInt64) on every call to solve. But there is no real reason to do this for a sequence of solve calls running on the same thread, and it leads to undesirable effects like non-reproduciblity of results (because it doesn't respect the user's rng choice).

It would be breaking, but I think we should drop reseeding if no seed is passed. If this has an impact on EnsembleProblems, then they should be updated to properly handle passing new unique seeds to spawned solvers when needed instead of trying to put this decision at the level of solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant