Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐛 | Bug]: MacOS: file saving not working from native MacOS software #8991

Closed
Tracked by #9115
Ironicbay opened this issue Nov 25, 2024 · 1 comment · Fixed by #9351 · May be fixed by #8997
Closed
Tracked by #9115

[🐛 | Bug]: MacOS: file saving not working from native MacOS software #8991

Ironicbay opened this issue Nov 25, 2024 · 1 comment · Fixed by #9351 · May be fixed by #8997
Assignees
@FirelightFlagboy
Labels
A-Client Area: Parsec desktop application A-MacOS Area: MacOS issue C-Bug Issue related to a bug I-Rust Impact: Rust-related stuff
Milestone
v3.2.4

Comments

@Ironicbay
Copy link
Contributor

Parsec version tested on:

3.2.0

Platforms tested on:

MacOS

Bug description:

This had to be fixed in V2 as well, see #2211 and #4198

Saving works fine from non-Apple software, so it's likely the same issue we previously encountered.

To replicate:

  • Open a .txt file inside a Parsec workspace, it should open with TextEdit by default
  • cmd+S fails.

Relevant output:

No response
@Ironicbay Ironicbay added C-Bug Issue related to a bug B-Triage Blocker: The issue is awaiting triage labels Nov 25, 2024
@FirelightFlagboy FirelightFlagboy added A-Client Area: Parsec desktop application A-MacOS Area: MacOS issue and removed B-Triage Blocker: The issue is awaiting triage labels Nov 27, 2024
This was referenced Nov 27, 2024
Open
Open
@mmmarcos mmmarcos added the I-Rust Impact: Rust-related stuff label Nov 29, 2024
@FirelightFlagboy FirelightFlagboy self-assigned this Nov 29, 2024
@FirelightFlagboy FirelightFlagboy mentioned this issue Dec 4, 2024
Closed
7 tasks
@mmmarcos mmmarcos added this to the v3.2.3 milestone Dec 9, 2024
@mmmarcos mmmarcos mentioned this issue Dec 11, 2024
Closed
@mmmarcos mmmarcos modified the milestones: v3.2.3, v3.2.4 Dec 17, 2024
@FirelightFlagboy FirelightFlagboy linked a pull request Jan 8, 2025 that will close this issue
Use patched fuser crate #8997
Draft
44 tasks
FirelightFlagboy added a commit that referenced this issue Jan 16, 2025
@FirelightFlagboy
Make setattr always return file attr even if no attr where changed
0133947 
Fix #8976, fix #8991
@FirelightFlagboy FirelightFlagboy linked a pull request Jan 16, 2025 that will close this issue
Fix mountpoint issues on macOS #9351
Merged
FirelightFlagboy added a commit that referenced this issue Jan 16, 2025
@FirelightFlagboy
Make setattr always return file attr even if no attr where changed
f762e46 
Fix #8976, fix #8991
@mmmarcos mmmarcos mentioned this issue Jan 16, 2025
Merged
FirelightFlagboy added a commit that referenced this issue Jan 16, 2025
@FirelightFlagboy @touilleMan
# This is a combination of 2 commits.
4ede584 
# This is the 1st commit message:

Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this issue Jan 16, 2025
@FirelightFlagboy @touilleMan
Make setattr always return file attr even if no attr where changed
78ba266 
Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this issue Jan 17, 2025
@FirelightFlagboy @touilleMan
Make setattr always return file attr even if no attr where changed
427cb13 
Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>
vxgmichel pushed a commit that referenced this issue Jan 17, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
0467065 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
@FirelightFlagboy
Copy link
Contributor

Fixed by #9351

FirelightFlagboy added a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Make setattr always return file attr even if no attr where changed
3bc89a8 
Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
d4bc2ba 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
bdaef8f 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
9f3a2dd 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
FirelightFlagboy added a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
5c10273 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
a901b68 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Jan 21, 2025
@FirelightFlagboy @touilleMan
Fix mountpoint issues on macOS (#9351)
0af9419 
* [rust] update `fuser` to `0.15.1`

Fix #9173

* Make `setattr` always return file attr even if no attr where changed

Fix #8976, fix #8991

Co-authored-by: Emmanuel Leblond <[email protected]>

* [rust] Update `ruzstd` to `0.7.3`

* Ignore `RUSTSEC-2024-0398`

Related to #8990

---------

Co-authored-by: Emmanuel Leblond <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FirelightFlagboy FirelightFlagboy

Labels
A-Client Area: Parsec desktop application A-MacOS Area: MacOS issue C-Bug Issue related to a bug I-Rust Impact: Rust-related stuff
Projects
None yet
Milestone
v3.2.4
Development

Successfully merging a pull request may close this issue.

Fix mountpoint issues on macOS Scille/parsec-cloud
Use patched fuser crate Scille/parsec-cloud
3 participants
@mmmarcos @FirelightFlagboy @Ironicbay