Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base installers shouldn't be stored pre-compressed #12

Open
aaaaalbert opened this issue Jul 8, 2015 · 1 comment
Open

Base installers shouldn't be stored pre-compressed #12

aaaaalbert opened this issue Jul 8, 2015 · 1 comment

Comments

@aaaaalbert
Copy link
Contributor

packager.py takes the compressed base installers, unpacks them, adds an installer-specific vesselinfo file to the resulting tar file or directory and then re-compresses to create the final, downloadable installer.

However, storing the base installers in compressed form really only generates CPU and disk load, without solving any problems. Modifying the tar file did get us into trouble previously, see #9.

I therefore propose to store the base installers in uncompressed form, i.e. as plain directories, and only compress them as the last step of the packager.

@JustinCappos
Copy link
Contributor

I think this may increase latency for a download. However, I do agree that
is unlikely to be the most important thing and agree this change makes
sense.

On Wed, Jul 8, 2015 at 11:47 AM, aaaaalbert [email protected]
wrote:

packager.py
https://github.com/SeattleTestbed/custominstallerbuilder/blob/master/common/packager.py
takes the compressed base installers, unpacks them, adds an
installer-specific vesselinfo file to the resulting tar file or directory
and then re-compresses to create the final, downloadable installer.

However, storing the base installers in compressed form really only
generates CPU and disk load, without solving any problems. Modifying the
tar file did get us into trouble previously, see
#9
#9.

I therefore propose to store the base installers in uncompressed form,
i.e. as plain directories, and only compress them as the last step of the
packager.


Reply to this email directly or view it on GitHub
#12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants