Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some functions don't manage readResponse correctly (SAMConfig return always false) #127

Closed
mywalkb opened this issue May 8, 2022 · 2 comments
Assignees
Labels
PN532 Label for PN532 UAY Unassigned yet

Comments

@mywalkb
Copy link

mywalkb commented May 8, 2022

I see some functions don't manage correctly the length 0 from readResponse.
For example SAMConfig return 0 length that it's correct from datasheet, but for this library return false.
I will not make a PR because because none manage it, if someone is interested I patched here, in this patch there are also some improvements.

@MatthewJeffson MatthewJeffson added UAY Unassigned yet PN532 Label for PN532 and removed UAY Unassigned yet labels Oct 9, 2024
@Cincinnatu
Copy link

Hello!Can you describe the changes that you have made?

@Lesords
Copy link

Lesords commented Nov 4, 2024

Hello,

I'm going to close this issue, feel free to re-open it if you have any other questions.

[Autocommentary]

@Lesords Lesords closed this as completed Nov 4, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PR Assemble Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PN532 Label for PN532 UAY Unassigned yet
Projects
Status: Done
Development

No branches or pull requests

4 participants