Skip to content

Commit 4fc2582

Browse files
authored
[py] Better error for downloads on local webdrivers (#15756)
Raise NotImplementedError when trying to call get_downloadable_files() or download_file() on any local WebDriver. These methods are only available on the parent WebDriver class (AKA Remote).
1 parent 43e6bb9 commit 4fc2582

File tree

6 files changed

+36
-0
lines changed

6 files changed

+36
-0
lines changed

py/selenium/webdriver/chromium/webdriver.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,3 +222,9 @@ def quit(self) -> None:
222222
pass
223223
finally:
224224
self.service.stop()
225+
226+
def download_file(self, *args, **kwargs):
227+
raise NotImplementedError
228+
229+
def get_downloadable_files(self, *args, **kwargs):
230+
raise NotImplementedError

py/selenium/webdriver/firefox/webdriver.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,3 +221,9 @@ def get_full_page_screenshot_as_base64(self) -> str:
221221
driver.get_full_page_screenshot_as_base64()
222222
"""
223223
return self.execute("FULL_PAGE_SCREENSHOT")["value"]
224+
225+
def download_file(self, *args, **kwargs):
226+
raise NotImplementedError
227+
228+
def get_downloadable_files(self, *args, **kwargs):
229+
raise NotImplementedError

py/selenium/webdriver/ie/webdriver.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,3 +75,9 @@ def quit(self) -> None:
7575
pass
7676
finally:
7777
self.service.stop()
78+
79+
def download_file(self, *args, **kwargs):
80+
raise NotImplementedError
81+
82+
def get_downloadable_files(self, *args, **kwargs):
83+
raise NotImplementedError

py/selenium/webdriver/safari/webdriver.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,3 +108,9 @@ def get_permission(self, permission):
108108
def debug(self):
109109
self.execute("ATTACH_DEBUGGER")
110110
self.execute_script("debugger;")
111+
112+
def download_file(self, *args, **kwargs):
113+
raise NotImplementedError
114+
115+
def get_downloadable_files(self, *args, **kwargs):
116+
raise NotImplementedError

py/selenium/webdriver/webkitgtk/webdriver.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,3 +59,9 @@ def quit(self):
5959
pass
6060
finally:
6161
self.service.stop()
62+
63+
def download_file(self, *args, **kwargs):
64+
raise NotImplementedError
65+
66+
def get_downloadable_files(self, *args, **kwargs):
67+
raise NotImplementedError

py/selenium/webdriver/wpewebkit/webdriver.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,3 +59,9 @@ def quit(self):
5959
pass
6060
finally:
6161
self.service.stop()
62+
63+
def download_file(self, *args, **kwargs):
64+
raise NotImplementedError
65+
66+
def get_downloadable_files(self, *args, **kwargs):
67+
raise NotImplementedError

0 commit comments

Comments
 (0)