Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with verified user icon and email on pages #162

Open
jahshaka opened this issue Nov 2, 2018 · 5 comments
Open

issues with verified user icon and email on pages #162

jahshaka opened this issue Nov 2, 2018 · 5 comments
Assignees

Comments

@jahshaka
Copy link

jahshaka commented Nov 2, 2018

we had decided that we would not show emails instead show "verified user" when a user is email verified... but this is poorly done and very hokey across the app.

it has bden partially implemented on android but its not in iOS which still shows the email address...

for eg

i send Sam $20 usd

  1. view his transaction receipt and it does not show the 'verified' shield on his avatar instead it shows a address book icon ? either a shield or nothing there please

  2. click on his avatar to take me to his contact page in my address book and now there is a shield on his avatar and it also shows a shield and says verified user in the header text under his name ... we no longer need a shield on his avatar if it says verified user in the header ?

  3. on the contact page of the address book above we should always show the full name currently its showing Samuel F

please clean up on android and then mirror to ios

@jahshaka
Copy link
Author

jahshaka commented Nov 2, 2018

so related to this as well

#112

the only place we show the email would be on the contact page in the address book

if you have done a transaction with them then the contact page should show the verified user icon on the avatar as well as the email address in the header...

if you havent done a transaction with the person then it just says 'verified user' if they are also email verified

currently on ios it shows the email and on android it shows verified user for all users and no email...

@jahshaka
Copy link
Author

jahshaka commented Dec 8, 2018

any updates here

@Ibar000
Copy link

Ibar000 commented Dec 11, 2018

@jayrulez would you mind unraveling exactly what is required here: specifically about "the only place we show the email would be on the contact page in the address book

if you have done a transaction with them then the contact page should show the verified user icon on the avatar as well as the email address in the header..."

thanks

@jayrulez
Copy link
Contributor

Whenever viewing another user in the app follow these rules:

For Activities (Requests, Sends etc...)
If the user has a verified email address then show a verified shield.

When viewing a contact:
If the user has a verified email address then show a verified shield.
If you have previously done a transaction with the user then show the user's email address if they have one.

@jahshaka can you please confirm that this is what is intended.

@jovi959
Copy link

jovi959 commented Dec 14, 2018

iOS Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants