Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID3v2: Remove invalid padding on write #262

Open
Serial-ATA opened this issue Oct 2, 2023 · 0 comments
Open

ID3v2: Remove invalid padding on write #262

Serial-ATA opened this issue Oct 2, 2023 · 0 comments
Labels
enhancement New feature or request low priority Something that is at least planned, but likely will not be worked on soon.

Comments

@Serial-ATA
Copy link
Owner

It's a common issue that padding will often stick around between tag edits, as it is typically not properly accounted for in the tag header size.

We currently just get the tag size from the header and replace that many bytes with the new tag when writing, similar to other libraries. The problem is, when a tag has invalid padding that isn't included in the size, it will remain in the file indefinitely.

It may be worth removing the padding if we can reliably detect it without destroying any important data.

@Serial-ATA Serial-ATA added the enhancement New feature or request label Oct 2, 2023
@Serial-ATA Serial-ATA added the low priority Something that is at least planned, but likely will not be worked on soon. label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Something that is at least planned, but likely will not be worked on soon.
Projects
None yet
Development

No branches or pull requests

1 participant