Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctrine/persistence bundle compatibility #93

Open
PeterMagyar opened this issue May 22, 2024 · 5 comments
Open

Doctrine/persistence bundle compatibility #93

PeterMagyar opened this issue May 22, 2024 · 5 comments

Comments

@PeterMagyar
Copy link

I tried to add this bundle to a sylius project(v.1.12.13) sf(6.4). According to composer its not possible because it's requirement is ^1.3 || ^2.0

and my project doctrine/persistence version is 3..2

@loevgaard
Copy link
Member

Could you open a PR? :)

@PeterMagyar
Copy link
Author

I really would like to but i found many other issue with compatibility. For example :
setono/doctrine-orm-batcher[v0.6.0, ..., v0.6.1] require php ^7.1 -> your php version (8.1.13) does not satisfy that requirement.

It seems like the "problem" is much more deeper than i thought at first :)

@loevgaard
Copy link
Member

What happens if you try to downgrade your own dependency?

@PeterMagyar
Copy link
Author

I would prefer to not downgrade any the bundles.

I tried it just for see that works or not. The composer require command with (--with-all-dependencies -- to downgrade where necessary) also failed. So it would not solve the problem either.

@encreinformatique
Copy link

encreinformatique commented Jul 17, 2024

It is coming from symfony/doctrine-bridge in 6.4 branch. They dropped support for doctrine/persistence 2.
It means we do have to stick to Symfony 5.4 LTS or a unmaintain version of the Sf bundles. (unacceptable in our case)

I prepared a PR but if it goes as in my fork, both static tests and integration won't pass although those files were not modified. I do not use Behat so I do not know if it related to compatibility or recent change.

Error: src/Controller/Action/Shop/ShowFeedAction.php:87:17: RiskyTruthyFalsyComparison: Operand of type bool|mixed contains type mixed, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
Error: src/DataProvider/DataProvider.php:94:63: ArgumentTypeCoercion: Argument 1 of Doctrine\Persistence\ManagerRegistry::getManagerForClass expects class-string, but parent type string provided (see https://psalm.dev/193)

and

PHP Fatal error:  Declaration of Behat\Mink\Driver\Selenium2Driver::visit(string $url) must be compatible with Behat\Mink\Driver\CoreDriver::visit($url) in /home/runner/work/SyliusFeedPlugin/SyliusFeedPlugin/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php on line 401

edit: I just saw the master branch is having those problems so definitively not related to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants