Skip to content

Latest commit

 

History

History
533 lines (356 loc) · 25.9 KB

CHANGELOG.md

File metadata and controls

533 lines (356 loc) · 25.9 KB
Raw

Pokémon Trading Card Game, Version 2

Types of Changes:



Bug Fixes For Base Game

  • June 11, 2024: 2 Files Changed
    • Change some mistaken calls to bank1calls

  • June 10, 2024: 2 Files Changed
    • Fix AI logic for using Dugtrio's Earthquake attack
    • Add AI logic for using Dragonite's Step In Pokémon Power (taken from poketcg2)

  • May 21, 2024: 3 Files Changed
    • Finish fixing the "Big Lightning" and "Dive Bomb" animations
    • Split "Gfx 12" and "Anims 1" into 2 banks
    • Split "Anims 4" and "Palettes1" into 2 banks

  • May 21, 2024: 17 Files Changed (bugs_and_glitches.md was also removed)
    • Fix the lower left tiles of the pool area in the Water Club using the wrong color
    • Fix the emblems in the Club entrances using some incorrect tiles
    • Fix a problem with the frame data being used for NPCs with a green palette
    • (Partially) Fix a problem with the "Big Lightning" duel animation
    • (Partially) Fix a problem with the "Dive Bomb" duel animation

  • May 6, 2024: 9 Files Changed (8 are Code Optimization)
    • Fix "Ninetails" typo

  • April 15, 2024: 1 File Changed
    • Fix the AI not checking the Unable_Retreat substatus before retreating

  • April 15, 2024: 24 Files Changed
    • Fix the AI repeating the Active Pokémon score bonus when attaching an Energy card
    • Fix designated cards not being set aside when the AI places Prize cards
    • Apply the AI score modifiers for retreating
    • Fix a flaw in AI's Professor Oak logic
    • Fix Rick never playing Energy Search
    • Fix Rick using the wrong Pokédex AI subroutine
    • Fix Chris never using Revive on Kangaskhan
    • Fix a flaw in the AI's Pokémon Trader logic for the PowerGenerator deck
    • Fix various flaws in the AI's Full Heal logic
    • Prevent the AI from attacking with a Pokémon Power after playing PlusPower and then evolving
    • Fix the AI never using Energy Trans to retreat
    • Fix Sam's practice deck checking for the wrong card ID
    • Fix various flaws in the AI logic for the Shift Pokémon Power
    • Prevent the AI from being able to use Cowardice without waiting a turn
    • Fix the wrong name being displayed in the Challenge Cup
    • Fix a flaw in the Card Pop logic when comparing player names
    • Add a missing return to the InitPromotionalCardAndDeckCounterSaveData function in src/engine/menus/deck_selection.asm


Code Optimization

  • June 22, 2024: 19 Files Changed
    • Delete "Func_7415", "SetNoLineSeparation", and "SetOneLineSeparation" from engine/duel.core.asm, replacing any calls with the 2 lines of code from the deleted function
    • Move "Func_61a1" to engine/duel/effect_functions.asm
    • Move "ZeroObjectPositionsAndToggleOAMCopy" to home/objects.asm
    • Move "WaitAttackAnimation" to home/duel.asm
    • Move "SetCardListHeader" and "SetCardListInfoBoxText" to home/menus.asm

  • June 19, 2024: 1 File Changed
    • Delete JPWriteByteToBGMap0 and add a slight optimization for PrintDuelResultStats

  • June 18, 2024: 6 Files Changed
    • Delete ResetDoFrameFunction functions, and replace each call with the requisite lines of code

  • June 9, 2024: 6 Files Changed
    • Remove some unnecessary farcalls and use "ldh" for "ld [hff__], a"

  • June 8, 2024: 1 File Changed
    • Revise/add code comments and perform minor code optimizations in engine/save.asm

  • June 8, 2024: 1 File Changed
    • Revise/add code comments and perform minor code optimizations in engine/overworld_map.asm

  • June 6, 2024: 40 Files Changed
    • Eliminate most tail calls in the non-ai engine files (replacing a call ret with a fallthrough/jr/jp)
    • Rearrange some functions in the non-ai engine files to replace some jp's with jr's or fallthroughs

  • June 3, 2024: 22 Files Changed
    • Rearrange some functions in the home bank to replace some jp's with jr's or fallthroughs
    • Eliminate remaining home bank tail calls (replacing a call ret with a fallthrough/jr/jp)
      • Intentially ignored BankpopROM tail calls (that function can't be jumped to)

  • May 29, 2024: 35 Files Changed
    • Refactor code to minimize use of unconditional jr's
    • Other minor optimizations, most of which involve jumps

  • May 27, 2024: 11 Files Changed
    • Refactor a variety of code pertaining to the effect functions
    • Fix numerous errors in the effect functions code
    • Replace some hexadecimal numbers with the appropriate icon tile offset constants
    • Miscellaneous Text Changes

  • May 17, 2024: 3 Files Changed
    • Review most of the code comments in the effect functions files
    • Replace many jp's with jr's and fallthroughs, moving functions as necessary
    • Refactor several effect functions

  • May 10, 2024: 2 Files Changed
    • Refactor some code in src/engine/duel/effect_functions2.asm

  • May 10, 2024: 2 Files Changed
    • Refactor some code in src/engine/duel/effect_functions.asm

  • May 8, 2024: 36 Files Changed
    • Remove some redundant code
    • Replace some jp's with jr's
    • Replace some conditional jumps to returns with conditional returns (e.g. "ret z" instead of "jr z, .done")
    • Refactor some code in src/engine/duel/effect_functions.asm and effect_functions2.asm
    • Removed references to Sand Attack substatus (since it was merged with Smokescreen substatus)
    • The changes to AIDecide_GustOfWind crash the game (Link to Bug Fix)

  • May 7, 2024: 9 Files Changed
    • Remove some redundant code

  • May 6, 2024: 9 Files Changed (1 is Bug Fix)
    • Eliminate some home bank tail calls (replacing a call ret with a fallthrough/jr/jp)
    • Replace some conditional jumps to returns with conditional returns (e.g. "ret z" instead of "jr z, .done")
    • Remove some redundant code
    • Refactor some code in src/engine/duel/effect_functions.asm
    • Add a couple of division functions to src/home/math.asm

  • May 4, 2024: 7 Files Changed
    • Combine various subroutines related to setting or resetting the carry flag for Effect Functions and AI Logic banks

  • May 4, 2024: 52 Files Changed
    • Comment out most unreferenced functions and move them to a section at the end of each file
    • Unlink debug_main.asm, debug_sprites.asm, unknown.asm, unused_copyright.asm, and unused_save_validation.asm from src/main.asm and src/layout.link
    • Remove some redundant lines of code
    • Replace some conditional jumps to returns with conditional returns (e.g. "ret z" instead of "jr z, .done")
    • Replace various conditional jumps to set carry subroutines in the home bank with jumps to the ReturnCarry function

  • May 4, 2024: 12 Files Changed
    • Replace any mistaken bank1calls with calls
    • Label several unlabeled functions in src/engine/duel/core.asm and effect_functions.asm

  • April 30, 2024: 26 Files Changed
    • Comment out many unreferenced functions in the home bank
    • Remove src/home/ai.asm and src/home/damage.asm and unlink them from src/home.asm
    • Transfer some functions out of the home banks
    • Eliminate some same bank tail calls (replacing a call ret with a fallthrough/jr/jp)
    • Replace some mistaken farcalls/bank1calls with calls
    • Relocating some of the home bank functions led to some crashes (Reversion #1, Reversion #2, Reversion #3)

  • April 29, 2024: 14 Files Changed
    • Remove some redundant lines of code
    • Eliminate some same bank tail calls (replacing a call ret with a fallthrough/jr/jp)
    • Replace some conditional jumps to returns with conditional returns (e.g. "ret z" instead of "jr z, .done")

  • April 15, 2024: 19 Files Changed (Half are Miscellaneous Changes)
    • Massively condense Effect Commands and Effect Functions


Miscellaneous Changes

  • June 26, 2024: 8 Files Changed
    • Remove some now unreferenced material and put it where it belongs (in debug files)

  • June 26, 2024: 17 Files Changed
    • Try to standardize the function comments that are used in the engine/menus files
    • Plus some corrections/optimizations/shuffling of functions in said files


  • June 22, 2024: 9 Files Changed
    • Add comments related to setting the carry flag for a variety of home bank functions
    • Perform minor optimizations in home/duel.asm related to setting the carry flag

  • June 21, 2024: 3 Files Changed
    • Try to standardize the function comments that are used in engine/bank20.asm and the engine/sequences files
    • Remove some unnecessary code from the aforementioned files

  • June 20, 2024: 3 Files Changed
    • Move debug.asm from engine/menus and debug_player_coordinates.asm from engine/overworld to engine/unused

  • June 20, 2024: 4 Files Changed
    • Try to standardize the function comments that are used in the engine/gfx files
    • Remove several unnecessary push/pops in engine/gfx/sprite_animations.asm

  • June 19, 2024: 7 Files Changed (Plus 5 Files Relocated)
    • Comment out a few more unreferenced functions in the home bank
    • Move debug_sprites, unused_copyright.asm, and unused_save_validation.asm from engine to engine/unused
    • Move debug_main.asm and unknown.asm from engine/menus to engine/unused

  • June 18, 2024: 21 Files Changed (4 of these were removed from the repository)
    • Shuffle some functions in the home bank for better organization
    • Delete the redundant JPHblankCopyDataHLtoDE function
    • Add a missing colon to fix a build error from the commit below this one

  • June 18, 2024: 5 Files Changed
    • Shuffle some functions in the home bank that are related to printing numbers (and use more accurate labels)

  • June 17, 2024: 3 Files Changed
    • Reorganize the functions in home/substatus.asm

  • June 17, 2024: 51 Files Changed
    • Try to standardize the function comments that are used in the home bank files
    • Also eliminate some redundant code and update a few more ld's to ldh's
    • Further adjustments made in This Commit

  • June 13, 2024: 1 File Changed
    • Make the default player name (Mark) mixed case and have it be displayed with halfwidth font tiles to match the rest of the game's text

  • June 9, 2024: 1 File Changed (technically 2 since I renamed the original sprite)
    • Use JappaWakka's updated Double Colorless Energy sprite (with 2 Energy symbols)

  • June 7, 2024: 17 Files Changed
    • Revise various texts and combine some texts that are identical

  • June 5, 2024: 10 Files Changed
    • Make small adjustments to the menu screens related to deck selection
    • Replace hand_cards icon with a deck_box icon I made (used to represent the active deck)
    • Also add a deck icon next to the other completed decks on the deck selection screens
    • Revise/add code comments and perform minor code optimizations in both engine/menus/deck_configuration.asm and engine/menus/deck/selection.asm
    • Replace all uses of "ld a, [hff__]" in the repository with "ldh a, [hff__]"
    • Alter the number fonts stored in gfx/fonts/full_width?/0_2_digits_kanji1.png

  • June 2, 2024: 16 Files Changed
    • Update the Glossary (both the overall display and the actual text information)
    • Increase the size of the font tile section in vram when viewing the Glossary from a duel
    • Create many new fullwidth and halfwidth font characters, plus 2 new text box symbols
    • Move a lot of texts from text3.asm to text2.asm (Needed more space for Glossary)
    • Move a lot of texts from text2.asm to text1.asm
    • Make some minor adjustments to several of the title menu texts in text3.asm

  • May 30, 2024: 1 File Changed
    • Attempt to identify all unused wram bytes (total is around 2 kilobytes)
    • Edit some of the existing comments in wram.asm and create some new ones as well

  • May 21, 2024: 22 Files Changed
    • Fix minor typos and remove end of line spaces in the text files
    • Adjust texts to better fit the 2 line display used by the text boxes
    • Rewrite some of the larger texts, like glossary pages and tutorial messages
    • Use spaces to center most of the Trainer and Energy card descriptions

  • May 15, 2024: 1 File Changed
    • Decrease the wait time during the overworld section of the game's intro

  • May 15, 2024: 2 Files Changed
    • Give Text Offsets its own bank (instead of sharing one with Text 1)

  • May 12, 2024: 4 Files Changed
    • Add text speed constants and increase the default text speed to the fastest setting

  • May 11, 2024: 1 File Changed
    • Adjust scroll arrows in the card album (no longer on top of the border)

  • May 10, 2024: 8 Files Changed
    • Replace the "No" text symbol with a fullwidth "#" and display leading zeroes in Pokédex numbers

  • May 8, 2024: 13 Files Changed
    • Remove dead space (ds $--) in the GFX and Text banks

  • May 6, 2024: 1 File Changed
    • Change the name of the rom file produced by this repository from poketcg.gbc to poketcg_v2.gbc

  • April 26, 2024: 1 File Changed
    • Align the list numbers in the top right of the card list header

  • April 17, 2024: 1 File Changed
    • Further Adjustments to box_messages.png

  • April 16, 2024: 3 Files Changed
    • Update fullwidth and halfwidth font graphics and some of the box messages

  • April 16, 2024: 1 File Changed
    • Replace the word "Hand" with the hand icon from the duel graphics in the play area screens

  • April 15, 2024: 19 Files Changed (Half are Code Optimization)
    • Remove rom matching comparison
    • Split "Decks" and "Cards" into 2 banks
    • Add another Text bank, which uses the newly created text14.asm
    • Add another Effect Functions bank, which uses the newly created effect_functions2.asm
    • Update a wide variety of duel texts


New Features

  • June 1, 2024: 2 Files Changed
    • Display lowercase halfwidth font characters
    • Increase size of half_width.png to account for future additions

  • May 15, 2024: 5 Files Changed
    • Add support for common accented characters (halfwidth and fullwidth)
    • Expand the halfwidth font graphics (at the cost of some kanji)
    • This commit caused a major text display glitch (Link to Bug Fix)

  • May 14, 2024: 3 Files Changed
    • The practice game with Sam at the start of the game is now optional

  • May 10, 2024: 1 File Changed
    • Add a scroll arrow to a Trainer or Pokémon attack card page when the description is continued on another page

  • April 16, 2024: 4 Files Changed
    • Display the Promostar symbol on card pages

  • April 15, 2024: 1 File Changed
    • Replace damage counter display with "current HP/max HP"
    • The maximum HP value of a Pokémon is now 250 (was 120)

  • April 15, 2024: 1 File Changed
    • Cards can now have weakness or resistance to colorless (Use WR_COLORLESS)


Other Bug Fixes And Commit Reversions

  • June 11, 2024: 1 File Changed
    • Use "farcall" when CheckIfCanEvolveInto_BasicToStage2 is accessed by the AI Logic 2 bank
    • This is a bug fix for This Commit

  • May 27, 2024: 1 File Changed
    • Revert a change to AIDecide_GustOfWind that was causing the game to crash
    • This is a bug fix for This Commit

  • May 24, 2024: 5 Files Changed
    • Put a few more functions back in the home bank
    • At least the booster pack one was causing a crash
    • This is a bug fix for This Commit

  • May 23, 2024: 8 Files Changed
    • Put all of the animation and palette data back in their original locations
    • This completely undoes This Commit that sorted all of the animation and palette data in the proper banks

  • May 22, 2024: 2 Files Changed
    • Revert some text changes relating to duel texts
    • This cancels out some of the changes from This Commit

  • May 15, 2024: 1 File Changed
    • Removed Fullwidth4 instead of 1 & 2 to fix the wrong characters being displayed
    • This is a major bug fix for This Commit

  • May 8, 2024: 2 Files Changed
    • Put Func_3bb5 back in the home bank
    • This is a possible bug fix for This Commit

  • May 7, 2024: 4 Files Changed
    • Put AIDoAction functions back in the home bank
    • This is a major bug fix for This Commit

  • May 7, 2024: 4 Files Changed
    • Revert some set carry flag optimizations in the AI Logic 1 bank
    • This cancels out some of the changes from This Commit

  • April 15, 2024: 8 Files Changed
    • Fix some text display issues caused by the first commit
    • This is a minor bug fix for This Commit


Potential Hacks

  • May 14, 2024: Only Need to Change 1 File
    • Instructions for skipping the mandatory practice duel with Sam
    • This is less relevant now that the practice duel is optional