Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Searching for stores no longer works #5388

Closed
2 tasks done
TheGreatSimo opened this issue Feb 12, 2025 · 4 comments · Fixed by #5397 · May be fixed by #5393
Closed
2 tasks done

[Bug]: Searching for stores no longer works #5388

TheGreatSimo opened this issue Feb 12, 2025 · 4 comments · Fixed by #5397 · May be fixed by #5393
Labels
Type: Bug Something isn't working

Comments

@TheGreatSimo
Copy link

TheGreatSimo commented Feb 12, 2025 •
edited
Loading

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

App

Expected behavior

When I entered the command shopify app dev --reset I expected the search for stores to work

Actual behavior

It didn't work

2025-02-12.20-46-54.mp4

Verbose output

normal output

Reproduction steps

  1. Shopify's latest version is 3.75.0.
  2. You have more than three stores.
  3. Run shopify app dev --reset.
  4. Select the app and try searching for the store.

Operating System

ubuntu

Shopify CLI version (shopify --version)

3.75.0

Shell

No response

Node version (run node -v if you're not sure)

22.13.0

What language and version are you using in your application?

Javascript
@TheGreatSimo TheGreatSimo added the Type: Bug Something isn't working label Feb 12, 2025
@graygilmore
Copy link
Contributor

@amcaplan I think this is from #5145

The default behavior of search also filters the resulting list but it looks like your version of search will show all results regardless of what the search input is. I think filtering would be good, particularly for orgs with many dev stores. What do you think?

@amcaplan amcaplan mentioned this issue Feb 14, 2025
Open
3 tasks
@amcaplan
Copy link
Contributor

@graygilmore you're right! I put up a quick PR to fix, but it might take a bit more time to get it right. By the way, you can always run with the --store flag to work around this prompt.

@TheGreatSimo
Copy link
Author

@amcaplan thank you! I downgraded the version and it works. It's not a big problem
I just wanted to report it for the community

@isaacroldan isaacroldan mentioned this issue Feb 17, 2025
Merged
3 tasks
@isaacroldan
Copy link
Contributor

A fix was deployed with version 3.75.2 :)
I'll close the issue, but please let me know if you find any other error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@graygilmore @isaacroldan @amcaplan @TheGreatSimo