Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge autopilot into bus #1640

Open
2 tasks done
ChrisSchinnerl opened this issue Oct 30, 2024 · 2 comments
Open
2 tasks done

Merge autopilot into bus #1640

ChrisSchinnerl opened this issue Oct 30, 2024 · 2 comments
Milestone

Comments

@ChrisSchinnerl
Copy link
Member

ChrisSchinnerl commented Oct 30, 2024

The autopilot API should be merged into the bus. That means

  • make autopilot a sub-package of bus
  • existing autopilot routes on bus can be removed see #1657
  • no more multi-autopilot support which simplifies the database schema see #1657
  • bus /scan endpoint should score host if autopilot is enabled
@ChrisSchinnerl ChrisSchinnerl converted this from a draft issue Oct 30, 2024
@ChrisSchinnerl ChrisSchinnerl added this to the v2.0.0 milestone Oct 30, 2024
@ChrisSchinnerl ChrisSchinnerl self-assigned this Nov 1, 2024
@ChrisSchinnerl ChrisSchinnerl removed their assignment Dec 2, 2024
@peterjan
Copy link
Member

@ChrisSchinnerl what's the reasoning behind scoring hosts in the scan endpoint if the autopilot is enabled? Do we still want to score a host when we perform checks on hosts in the maintenance loop? Do we want to scan more frequently? The reason I'm asking is the LowScore field which needs calculateMinScore, which we calculate across all hosts. There's many ways around that but before diving in I figured I'd ask for a little more context.

@ChrisSchinnerl
Copy link
Member Author

The idea was that when you manually scan a host via the UI, you immediately get feedback as a user and don't need to wait for the maintenance to run. So we'd still have the regular maintenance but additionally a scan would also perform some checks.

That said I think we can hold off on that part until v2.1 or v3.0. We might not want to continue having a LowScore check anyway which would then simplify adding this.

@peterjan peterjan moved this from Todo to In Progress in Sia Dec 21, 2024
@peterjan peterjan modified the milestones: v2.0.0, v3.0.0 Dec 21, 2024
ChrisSchinnerl added a commit that referenced this issue Jan 10, 2025
…1767)

This PR restructures the autopilot in a way that makes it easier to
eventually move the autopilot and make it a subsystem of the bus. This
focuses mostly on the contractor; the next step would be to fix the
catch-22 we have while constructing the migrator. Getting these out of
the way should make it a lot easier to merge the autopilot into the bus.
I considered moving pruning to the contractor, but I'm still 50–50 on
that. A quick-and-dirty way to merge the autopilot is to keep using a
bus client, but I figured it's a good opportunity to clean things up a
bit because it's grown unwieldy.

Related to #1640.
@ChrisSchinnerl ChrisSchinnerl modified the milestones: v2.0.0, v2.1.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants