Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(task): update the preference API to handle generic interfaces for valueType #7063

Open
shivanshuraj1333 opened this issue Feb 7, 2025 · 1 comment
Assignees

Comments

@shivanshuraj1333
Copy link
Member

shivanshuraj1333 commented Feb 7, 2025

Related to: #6815
We want to support user based pins for third party api monitoring using preference API.

@shivanshuraj1333 shivanshuraj1333 self-assigned this Feb 7, 2025
@vikrantgupta25 vikrantgupta25 changed the title [feat] Make preference API compatible for Third Party Api monitoring views (task): update the preference API to handle generic interfaces for valueType Feb 7, 2025
@vikrantgupta25
Copy link
Member

  • Update the preference API to accept generic interface{} for the value type, allowed values should also follow the same
  • We need to think about how to validate the generic types with the provided allowed values as well
  • Allow to not have any check in place for certain values. like bypass the allowedValues and range checks as well
  • Updates should not end up making the preference store a property bag without any validations in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants