Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner otheragent2 resets to initialization #6

Closed
cooijmanstim opened this issue Mar 7, 2023 · 2 comments
Closed

Inner otheragent2 resets to initialization #6

cooijmanstim opened this issue Mar 7, 2023 · 2 comments

Comments

@cooijmanstim
Copy link

There is a bug in inner_step_get_grad_otheragent2 where the return value uses trainstate_th2.params and trainstate_val2.params. I think that should be trainstate_th2_.params and trainstate_val2_.params? As it is, it takes params from the trainstates in the global scope which haven't been trained. However, with the way the result of inner_step_get_grad_otheragent2 is used in the caller, I think this bug should have no effect unless args.inner_steps > 2.

trainstate_th2_, trainstate_th2.params, trainstate_val2_, trainstate_val2.params,

@Silent-Zebra
Copy link
Owner

Thanks for pointing this out! I think you're right in your comment and the effect. I'll fix this and the other issue you pointed out.

@Silent-Zebra
Copy link
Owner

Closing as fixes have been implemented and experiments rerun (see updated readme)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants