From e8bb02576d8870f8cca1cf97fb0d6c726b3c4845 Mon Sep 17 00:00:00 2001 From: Joris Vaillant Date: Tue, 11 Mar 2025 15:26:40 +0100 Subject: [PATCH 1/2] veg: Fix Visual Studio 17.13 internal compiler error --- include/proxsuite/linalg/veg/type_traits/constructible.hpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/proxsuite/linalg/veg/type_traits/constructible.hpp b/include/proxsuite/linalg/veg/type_traits/constructible.hpp index 1872b3e59..ab5d028ba 100644 --- a/include/proxsuite/linalg/veg/type_traits/constructible.hpp +++ b/include/proxsuite/linalg/veg/type_traits/constructible.hpp @@ -166,6 +166,12 @@ template struct MoveFn { T&& value; + // We should define a constructor to avoid an Internal compiler error with + // Visual Studio 17.13 + MoveFn(T&& v) + : value(VEG_FWD(v)) + { + } VEG_INLINE constexpr auto operator()() const&& VEG_NOEXCEPT_IF( VEG_CONCEPT(nothrow_movable)) -> T { From a5b83f752fa9e1de58ee9c1e72c747a8e29d1ef4 Mon Sep 17 00:00:00 2001 From: Joris Vaillant Date: Tue, 11 Mar 2025 15:28:49 +0100 Subject: [PATCH 2/2] changelog: Add entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3144d7e1b..aefad0a67 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ### Fixed * Fix an arcane compilation issue on Clang-19 ([#379](https://github.com/Simple-Robotics/proxsuite/pull/379)) * Replace `!= None` with `is not None` in Python bindings ([#375](https://github.com/Simple-Robotics/proxsuite/pull/375)) +* Fix Internal compiler error with Visual Studio 17.13 ([#384](https://github.com/Simple-Robotics/proxsuite/pull/384)) ### Changed * Upgrade nanobind submodule to v2.5.0 ([#378](https://github.com/Simple-Robotics/proxsuite/pull/378))