Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential typo or unused code #5

Open
lulebe opened this issue Jun 14, 2018 · 1 comment
Open

Potential typo or unused code #5

lulebe opened this issue Jun 14, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@lulebe
Copy link

lulebe commented Jun 14, 2018

this.lastPortCount = this.portCount in your midi-adapter.js on line 32 assigns a function to an integer variable. It's overwritten in the only case it's being used after that I think, so you could probably remove it, or change it to calling the function instead of assigning it.

@Simsso Simsso self-assigned this Jun 14, 2018
@Simsso Simsso added the bug Something isn't working label Jun 14, 2018
@Simsso
Copy link
Owner

Simsso commented Jun 14, 2018

Thanks you for pointing that out. That's a mistake I've made. I'll fix it.

The MIDI relay part is not too important after all because (as I learnt after publishing the video) there is a MIDI API available in Chrome. Version 2 of this project is going to make use of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants