Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkyrien Skies 2 has problem with Connector Extras #33

Open
Corn-on-the-Orb opened this issue Apr 1, 2024 · 22 comments
Open

Valkyrien Skies 2 has problem with Connector Extras #33

Corn-on-the-Orb opened this issue Apr 1, 2024 · 22 comments
Labels
bug Something isn't working

Comments

@Corn-on-the-Orb
Copy link

Corn-on-the-Orb commented Apr 1, 2024

Describe the bug

I tried to download VS2 into a modpack using connector, but always crashes in startup with something to do with 'reach_entity_attributes' mixins

Steps to reproduce

  1. Download Better MC
  2. Add VS2 and any dependancies
  3. disable ryoamic lights
  4. attempt to launch game
    ...

Logs

https://mclo.gs/5T0Pw6e

Additional context

No response

@Corn-on-the-Orb Corn-on-the-Orb added the bug Something isn't working label Apr 1, 2024
@Groupix05
Copy link

Same here, https://mclo.gs/laogcFi
I tried with only libs and optimization mods, because It's really hard to find THE mod that crash the game

@Billnotic
Copy link

https://pastebin.com/7TJCS8rq

Here is a log for a crash with 165 mods installed. It seems that the crash will only happen if there are 165 or more enabled. Why this is the case, I have no clue.

@DaftHunk
Copy link

DaftHunk commented Apr 3, 2024

Same problem here :
https://pastebin.com/AvUxkYip

Disabling Valkyrian Skies 2 make the game launch

@zxy19
Copy link

zxy19 commented Apr 8, 2024

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

@Corn-on-the-Orb
Copy link
Author

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

where did you find the module in the jar file and how did you go about doing that?

@zxy19
Copy link

zxy19 commented Apr 8, 2024

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

where did you find the module in the jar file and how did you go about doing that?

Just download the source code and open "build.gradle.kts", then remove line below:

includeProject("reach-entity-attributes")

then execute gradle task "Jar" on project ConnectorExtra and get jar in build/lib.

@Corn-on-the-Orb
Copy link
Author

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

where did you find the module in the jar file and how did you go about doing that?

Just download the source code and open "build.gradle.kts", then remove line below:

includeProject("reach-entity-attributes")

then execute gradle task "Jar" on project ConnectorExtra and get jar in build/lib.

Im using winrar to edit files and stuff and I cant seem to find "build.gradle.kts" anywhere, what software are you using to edit the jar with?

@zxy19
Copy link

zxy19 commented Apr 8, 2024

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

where did you find the module in the jar file and how did you go about doing that?

Just download the source code and open "build.gradle.kts", then remove line below:

includeProject("reach-entity-attributes")

then execute gradle task "Jar" on project ConnectorExtra and get jar in build/lib.

Im using winrar to edit files and stuff and I cant seem to find "build.gradle.kts" anywhere, what software are you using to edit the jar with?

I'm not modifying the release jar file but building a new one from source code.
If you don't wanna do so, you can try this file I build myself.
ConnectorExtras-1.10.0+1.20.1+dev-g9a9680e.zip
Just simply removed supply for "Reach Entity Attributes" which currently incompat with vs2.

@Corn-on-the-Orb
Copy link
Author

ahhh i see what you mean now thanks a lot for the help, ive downloaded and made the change to the source code but not sure how to do the final build step you mentioned?

@zxy19
Copy link

zxy19 commented Apr 8, 2024

Refere

I'm not a skilled java developer and cannot help you a lot. You can refer to forge document/gradle document to learn more.

@Corn-on-the-Orb
Copy link
Author

removing the module didnt seem to do anything for me but make connector stop working with it, unless ive done it wrong... so ive yet to find a solution to this problem aside rom removing the mods entirely.

@Liamgrayskull
Copy link

Posting a link from the discord thread on the same issue here to bridge some information
https://discord.com/channels/1141048834177388746/1222663653233262764
Is there any verifiable way to easily find what mods depend on reach-entity-attributes?

@Corn-on-the-Orb
Copy link
Author

Posting a link from the discord thread on the same issue here to bridge some information https://discord.com/channels/1141048834177388746/1222663653233262764 Is there any verifiable way to easily find what mods depend on reach-entity-attributes?

which server is that from?

@Groupix05
Copy link

which server is that from?

Sinytra server https://discord.com/invite/mamk7z3TKZ

@awesomebossdj7
Copy link

strange doesnt happen for me, although i dont disable ryoamic lights

@colinxu2020
Copy link

Rebuild is not required, you can remove META-INF/jarjar/reach-entity-attributes-2.4.0.jar and remove line three to line thirteen in META-INF/jarjar/metadata.json in release jar file.

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

where did you find the module in the jar file and how did you go about doing that?

Just download the source code and open "build.gradle.kts", then remove line below:

includeProject("reach-entity-attributes")

then execute gradle task "Jar" on project ConnectorExtra and get jar in build/lib.

Im using winrar to edit files and stuff and I cant seem to find "build.gradle.kts" anywhere, what software are you using to edit the jar with?

I'm not modifying the release jar file but building a new one from source code. If you don't wanna do so, you can try this file I build myself. ConnectorExtras-1.10.0+1.20.1+dev-g9a9680e.zip Just simply removed supply for "Reach Entity Attributes" which currently incompat with vs2.

@nikoraasu
Copy link

Will this be fixed? The band aid fix does not do it for me as certain mods I am using rely on "reach-entity-attributes" from ConnectorExtras.

@Groupix05
Copy link

This crash will be fixed in a newer version of Valkyrien Skies, before this year I think. Check their announcement on their discord.

@tlitookilakin
Copy link

I have no idea how reliable this is, but I was able to get it working by adding a false dependency to VS, to force VS to load before REA.

If you want to try this, it can be done by opening up the VS jar (using 7zip or winrar) and adding the following to the end of the mods.toml file

[[dependencies.valkyrienskies]]
modId = "reach-entity-attributes"
mandatory = false
ordering = "BEFORE"

@gkr0013
Copy link

gkr0013 commented Nov 29, 2024

I had the same issue when adding Valkyrien Skies to the SteamPunk modpack (who uses ConnectorExtra for the Eldritch mod)

[[dependencies.valkyrienskies]]
modId = "reach-entity-attributes"
mandatory = false
ordering = "BEFORE"

Doesn't work for me.

But, remove "reach-entity-attributes-2.4.0.jar" in META-INF/jarjar/metadata.json works.
I don't know what effect it will have on the game...

@tlitookilakin
Copy link

I'm not able to remove REA as I have mods that rely on it.

@TowardtheStars
Copy link

It works for me, thanks.

Versions

Module Version
Minecraft 1.20.1
Forge 47.3.5
Sinytra Connector 1.0.0-beta.46
Connector Extras 1.11.2+1.20.1
Valkyrien Skies 2.3.0-beta.5

Rebuild is not required, you can remove META-INF/jarjar/reach-entity-attributes-2.4.0.jar and remove line three to line thirteen in META-INF/jarjar/metadata.json in release jar file.

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

where did you find the module in the jar file and how did you go about doing that?

Just download the source code and open "build.gradle.kts", then remove line below:

includeProject("reach-entity-attributes")

then execute gradle task "Jar" on project ConnectorExtra and get jar in build/lib.

Im using winrar to edit files and stuff and I cant seem to find "build.gradle.kts" anywhere, what software are you using to edit the jar with?

I'm not modifying the release jar file but building a new one from source code. If you don't wanna do so, you can try this file I build myself. ConnectorExtras-1.10.0+1.20.1+dev-g9a9680e.zip Just simply removed supply for "Reach Entity Attributes" which currently incompat with vs2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests