Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Make searching less trict #59

Open
AyhamAl-Ali opened this issue Apr 22, 2024 · 1 comment
Open

💡 Make searching less trict #59

AyhamAl-Ali opened this issue Apr 22, 2024 · 1 comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. frontend Issues that require frontend code changes (HTML, CSS, JS) good first issue Good for newcomers priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@AyhamAl-Ali
Copy link
Member

AyhamAl-Ali commented Apr 22, 2024

e.g. Vectors - Length wouldn't be matched if user searched for vectors length so something like this would easily be fixed by excluding/filtering some symbols from titles (only) as otherwise it may match unexpected results + heavier process. Right now I am thinking of excluding the regex [-/&\(\)]

Thanks to @APickledWalrus for this finding

Issue:
image

Expectation: (without using -)
image

@AyhamAl-Ali AyhamAl-Ali added enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue Good for newcomers priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). frontend Issues that require frontend code changes (HTML, CSS, JS) labels Apr 22, 2024
@Romitou
Copy link
Member

Romitou commented May 7, 2024

Perhaps it would be interesting to use string comparison algorithms such as Levenshtein or Jaro-Winkler to provide results similar to the search if there are no results with the strict search?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. frontend Issues that require frontend code changes (HTML, CSS, JS) good first issue Good for newcomers priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Development

No branches or pull requests

2 participants