🚀 Add event values to events in docs #5690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added EventValueInfo#getTime() - Added EventValueInfo#isEventExcluded(Class) - Overloaded EventValueInfo instructor and deprecated the old one due to `time` param - Added EventValues#getPerEventEventValues() for getting all events values per event -- useful for docs
AyhamAl-Ali
added
feature
APickledWalrus
requested changes
May 12, 2023
| @@ -68,6 +75,7 @@ public class HTMLGenerator { | |||
| private final File template; | |||
| private final File output; | |||
| private final String skeleton; | |||
| private Map<Class<? extends Event>, List<EventValues.EventValueInfo<?, ?>>> eventValuesCache = new HashMap<>(); | |||
There was a problem hiding this comment.
Could probably use a MultiMap here
|
|
||
| /** | ||
| * Whether the provided event is one of the excluded events of this {@link EventValueInfo} | ||
| * @return Either {@link #TIME_PAST}, {@link #TIME_NOW} or {@link #TIME_FUTURE} |
There was a problem hiding this comment.
i think this return javadoc is wrong ;)
| prefix = "past "; | ||
| else if (eventValueInfo.getTime() == EventValues.TIME_FUTURE) | ||
| prefix = "future "; | ||
| String className = eventValueInfo.c.getSimpleName().toLowerCase(Locale.ENGLISH); |
There was a problem hiding this comment.
should this use the ClassInfo name instead of replacing?
Co-authored-by: Patrick Miller <[email protected]>
TheLimeGlass
requested changes
Jul 11, 2023
| @@ -68,6 +75,7 @@ public class HTMLGenerator { | |||
| private final File template; | |||
| private final File output; | |||
| private final String skeleton; | |||
| private Map<Class<? extends Event>, List<EventValues.EventValueInfo<?, ?>>> eventValuesCache = new HashMap<>(); | |||
There was a problem hiding this comment.
Should clear this cache after the templates have been generated, we don't need it sitting in here.
Moderocky
force-pushed
the
master
branch
2 times, most recently
from
bd134d0
to
3f08853
Compare
Co-authored-by: LimeGlass <[email protected]>
Co-authored-by: LimeGlass <[email protected]>
|
closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EventValueInfo#getTime()EventValueInfo#isEventExcluded(Class)EventValueInfoconstructor and deprecated the old one due totimeparamEventValues#getPerEventEventValues()for getting all events values per event -- useful for docsPreview
nvm about the broken if condition, that's from my side
Target Minecraft Versions:
Requirements:
Related Issues: