-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media URLs seem incorrect when not local #1653
Comments
@dustin what kind of example would be good in the docker compose? We have this right now: Line 97 in 8f3d7c8
Are you open to a suggestion / PR? #2 - By default it just writes to the local filesystem. You can set up AWS + set storage type to be S3 instead (https://github.com/Skyvern-AI/skyvern/blob/main/skyvern/forge/app.py#L27) |
I had to set For the media (2), all of these things write to the local filesystem, don't they? The surprising part is that the URLs are all file:// which wouldn't work in many cases (e.g., writing to |
what is the solution for watch video recording, for a local installation on kubernetes ? Not allowed to load local resource: file:///data/artifacts/tsk_362042468532950184/00_0_stp_362042468532950186/2025-02-19T15:09:46.906620_a_362042494302753966_recording.webm |
I'm seeing the same problem; My But the recordings are not working.
Please re-open this issue. |
idk how but now it's work.. i set this: ![]() |
I found the problem. The conversation from
and that is only called for task details here
The problem I'm seeing is for workflow details skyvern/skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunRecording.tsx Line 5 in 2d24055
I made a quick and dirty hack locally by changing that function to convert the URL, like this import { useWorkflowRunQuery } from "../hooks/useWorkflowRunQuery";
import { artifactApiBaseUrl } from "@/util/env";
function WorkflowRunRecording() {
const { data: workflowRun } = useWorkflowRunQuery();
console.log(workflowRun)
let recordingURL = workflowRun?.recording_url;
if (recordingURL?.startsWith("file://")) {
recordingURL = `${artifactApiBaseUrl}/artifact/recording?path=${recordingURL.slice(7)}`;
}
return recordingURL ? (
<video src={recordingURL} controls className="w-full rounded-md" />
) : (
<div>No recording available for this workflow</div>
);
}
export { WorkflowRunRecording }; A better fix would be to make |
Great find @mingfang -- this is a pernicious bug. Are you open to opening a PR? |
@suchintan can you please review my PR? |
I noticed in console two problems:
I was able to work around #1 by specifying
VITE_ARTIFACT_API_BASE_URL=http://remotehost:9090
(very sensitive to trailing slash).It would probably be good to include an example in the docker compose file.
But for 2, I don't have a workaround. It seems to just always want to serve that from a place that won't exist on my filesystem.
The text was updated successfully, but these errors were encountered: