Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lintian builds warnings for libs, add versions and sonames #225

Open
krekhovx opened this issue Feb 22, 2025 · 0 comments
Open

Fix Lintian builds warnings for libs, add versions and sonames #225

krekhovx opened this issue Feb 22, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@krekhovx
Copy link

krekhovx commented Feb 22, 2025

Hi, I from Debian community. I'm trying to package your software into a Debian package. During the process of building the package I noticed some warnings from the Lintian utility (the lack of sonames in libraries and versions).
Please look at the libs-build-corrections.patch:

Forwarded: yes
Last-Update: 2025-02-22
Author: Kirill Rekhov <[email protected]>
Description: Fix Lintian builds warnings for libs, add versions and sonames
Bug-Clipboard: https://github.com/Slackadays/Clipboard/issues/225

--- clipboard-0.10.0.orig/src/cbwayland/CMakeLists.txt
+++ clipboard-0.10.0/src/cbwayland/CMakeLists.txt
@@ -36,7 +36,7 @@ add_custom_target(cbwayland_generatedhea
   DEPENDS "${GENERATED_XDG_SHELL_HEADER}"
 )
 
-add_library(cbwayland MODULE
+add_library(cbwayland SHARED
   src/fd.cpp
   src/wayland.cpp
 
@@ -71,4 +71,9 @@ target_include_directories(cbwayland PRI
   ${GENERATED_INCLUDE_DIR}
 )
 
+set_target_properties(cbwayland PROPERTIES
+  VERSION 1.0
+  SOVERSION 1
+)
+
 install(TARGETS cbwayland LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR})
--- clipboard-0.10.0.orig/src/cbx11/CMakeLists.txt
+++ clipboard-0.10.0/src/cbx11/CMakeLists.txt
@@ -1,7 +1,12 @@
-add_library(cbx11 MODULE
+add_library(cbx11 SHARED
   src/x11.cpp
 )
 
+set_target_properties(cbx11 PROPERTIES
+  VERSION 1.0
+  SOVERSION 1
+)
+
 target_link_libraries(cbx11
   ${X11_LIBRARIES}
   gui
@krekhovx krekhovx added the bug Something isn't working label Feb 22, 2025
@krekhovx krekhovx changed the title Fix builds warnings for libs, add versions and sonames Fix Lintian builds warnings for libs, add versions and sonames Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant