Petrolpark's Mod(s) break Tinkers' Construct fluid tanks

[CaptainMarTuuk]

Minecraft Version

1.20.1

Modloader

Forge

Modloader Version

v. 1.269.1.22113

Mantle Version

Mantle 1.11.28 for 1.20.1

Tinkers' Construct Version

Any version on 1.20.1

Describe your issue

Known compatibility issue with Petrolpark's mods. Petrol's Parts (Create add-on) and Destroy break fluids in all other mods, including Create itself and Tinker's Construct.

This issue is NOT caused by Tinkers Construct OR Petrol's Parts/Destroy themselves. Instead, it is the library mod that the latter two depend on: Petrolpark Library. Because both Petrol's Parts and Destroy require this library however, using either of them will cause the issue. The issue is only present in the versions of the library mod uploaded after 01/06/2025. As of writing, all versions after this date will break fluids in one way or another.

The ONLY way to fix this is either:

1. Uninstalling the Petrolpark Library mod (and therefore any of his other Create addons) entirely.
2. Rolling back your install of Petrolpark Library (and any of its dependents) to an earlier version that doesn't cause these issues. The latest version that I have tested that doesn't cause issues is the one uploaded on 01/06/2025. If you roll back all mods to this version, the issue should not persist and all mods will work as intended.

Crash Report

No response

Other mods

Petrolpark Library

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Searched open issues, Checked pinned issues, Searched closed issues, Checked the FAQ, Checked the in game books

[KnightMiner]

Thanks. Normally I'd suggest crossposting to their issue trackers as well, but the author doesn't have an issue tracker. I know they have a discord but discord is not an issue tracker.

Hopefully this issue will reduce future reports of this to our discord.

[NyanMC]

i suspect this method is related to the issue https://github.com/petrolpark/Create-Library/blob/main/src/main/java/com/petrolpark/mixin/FluidTankMixin.java#L24

i cannot guarantee that's the cause, but it IS overwriting a method in a forge capability which just screams "terrible idea" to me. plus, the class in question is called FluidTank

[KnightMiner]

Leave the issue open. I know its nothing we can fix, but people don't look at closed issues.

[petrolpark]

I have now fixed this. Apologies for causing grief through your Discord.

(Also, the fact it was an overwrite was temporary spit and duct tape to get a feature up and running, which I forgot to replace with a clean mixin afterwards (this has obviously now been done)). The issues tracker being disabled is an an artifact of when the library only had one dependent, but I'll reenable it.