Shields break like vanilla tools

[TerravoltPrime]

Minecraft Version

1.20.1

Modloader

Forge

Modloader Version

47.3.22

Mantle Version

1.11.36

Tinkers' Construct Version

3.1.9.1.19

Describe your issue

plate shields break when durability reaches zero like vanilla tools. (traveler's shield too)

Crash Report

No response

Other mods

None

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

I did not search

[KnightMiner]

Looked into this issue, it is caused by my fix for a different shield bug that we had previously just installed a workaround in tinkers. I reported it to Forge at MinecraftForge/MinecraftForge#10344, and confirmed this only affects 1.20.1 Tinkers (1.19.3 is when the patch was introduced, and the relevant code is missing since 1.20.6).

I am not sure of a good workaround yet, I have a few ideas but they all have negative side-effects. A workaround may be needed if we wish to maintain NeoForge compatibility though, as only Forge is still supported on 1.20.1.

[KnightMiner]

Digging into this more, seems Forge has a nicely placed event that lets me bypass vanilla shield damage code entirely, so that will give me a fix for this without losing Neo compat.

Bug fix on Forge's side is still valuable for any mods not using the event, I just happened to already have a listener in place that was processing tool stacks so it saves another tool stack creation.