-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feeder] Provide CLI arg to hide terminal #8
Comments
pulling from an old discord conversation, this probably requires a switch to WinMain/windows subsystem, and conditional AllocConsole (on windows, other platforms don't even need to care i think might be another way to handle it, not sure. EDIT: also might handle it other way 'round, hide by default, show by arg. |
Debating whether this would be an easier way to go: https://github.com/mpv-player/mpv/blob/16f0cd546d4aa5fff43ba13ac9c3cf8fbb1c3433/osdep/win32-console-wrapper.c would move whether to show console or not to "run the *.com or the *.exe", with the idea that you run the com file from commandline to get output, and just run the exe file otherwise. Prior art: https://gitlab.com/CalcProgrammer1/OpenRGB/-/merge_requests/99 |
some prior art that may be helpful (in particular, the issues with the approach that were raised): |
yeah i had seen that too. i think my original planned approach wouldn't run into those issues, but shrug |
It would be good for the feeder app to be hidden when launching steamvr - having many popups when in vr is a rough user experience.
At a minimum we should have a cli arg to hide the window and have that cli arg called by default when steamvr autolaunches the overlay. It might also be nice if the feeder app logged its output to a file, just so we have a way of diagnosing bugs without needing to view the terminal popup.
The text was updated successfully, but these errors were encountered: