Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlimeVR Feeder doesn't work well with OVR Space Calibrator #40

Open
kitlith opened this issue Mar 29, 2023 · 3 comments
Open

SlimeVR Feeder doesn't work well with OVR Space Calibrator #40

kitlith opened this issue Mar 29, 2023 · 3 comments
Labels
Priority: Normal The default priority Type: Bug Something isn't working

Comments

@kitlith
Copy link
Member

kitlith commented Mar 29, 2023

The approach used in #24 to solve #20 did not take into account OVR Space Calibrator. Since we're calculating from raw space, we end up getting the offsets prior to calibration, instead of after calibration.

@kitlith kitlith added the Type: Bug Something isn't working label Mar 29, 2023
@ButterscotchV ButterscotchV added the Priority: Normal The default priority label May 27, 2023
@kitlith
Copy link
Member Author

kitlith commented Jun 26, 2023

I think there's two approaches we could take here:

  • Only use static standing space for the HMD height above ground level, and send it as a separate field.
    • This simplifies everything else that interacts with steamvr, since they can just care about standing space.
    • I think this is the route I'm inclined to take, given the issues I had applying the offset in the overlay.
  • Try to calculate an offset from 'current' standing space to 'static' standing space, and apply that to standing space instead of coming from raw space.
    • we'd essentially be querying what the current playspace offset is every frame, per item that needs to interact with steamvr.

@kitlith
Copy link
Member Author

kitlith commented Jun 26, 2023

blinks wait, did we ever work okay with space calibrator? we switched from using raw space to using a modified raw space. why would that break space calibrator?

EDIT: it was reported as an issue with controllers -- i.e. feeder app's domain, and not that it worked previously. Updating title.

@kitlith kitlith changed the title [Regression] SlimeVR no longer works well with OVR Space Calibrator SlimeVR Feeder doesn't work well with OVR Space Calibrator Jun 26, 2023
@kitlith
Copy link
Member Author

kitlith commented Jun 26, 2023

I am worried that we'll still have issues if I work around it in feeder app, but someone offsets the headset to match the controllers instead of the controllers to match the headset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Normal The default priority Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants