Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort GUI filtering / manufacturer property issue #1236

Open
2 tasks
Eirenliel opened this issue Nov 11, 2024 · 0 comments
Open
2 tasks

Sort GUI filtering / manufacturer property issue #1236

Eirenliel opened this issue Nov 11, 2024 · 0 comments
Labels
Area: GUI Related to the GUI Priority: Normal The default priority Status: Help Wanted Needs some help to make progress Type: Bug Something isn't working

Comments

@Eirenliel
Copy link
Member

Eirenliel commented Nov 11, 2024

          > Also a PR should clearly say what the change does, why isSlime matters? I have no idea what this change means for HID devices that aren't original slimes, for example
          > 
          > I should have added, isSlime is how the GUI filters when you select the option to only show HMD and Slime trackers
          > 
          > so there is already DIY slimes or any slime made by third-party, is this an original slime? I don't know what type/manufacturer is appropriate, or if this is a wrong implementation for the intended outcome

Originally posted by @sctanf in #1235 (comment)

We want to have Manufacturer field to ideally display an actual manufacturer. But right now the UI uses it for filtering and converts into nebulous isSlime check that just checks manufacturer, instead of checking some other field. This needs to be remedied at some point:

  • Find a better property for UI to filter on when you check the show only trackers
  • Add manufacturer field to firmware and protocol, display it properly in UI and in other info, make it definable in build parameters so manufacturers could define it themselves if they want
@ButterscotchV ButterscotchV added Type: Bug Something isn't working Status: Help Wanted Needs some help to make progress Priority: Normal The default priority Area: GUI Related to the GUI labels Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: GUI Related to the GUI Priority: Normal The default priority Status: Help Wanted Needs some help to make progress Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants