You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That leads to unexpected results for the users (myself included):
In [18]: resp, status=jobs_api.getJobDetails('foo')
Non200response:404RequestId:UnknownURL:https://api.smartling.com/jobs-api/v3/projects/3bea86d16/jobs/fooresponse:b'{"response":{"code":"NOT_FOUND_ERROR","errors":[{"key":"not.found","message":"Translation job is not found","details":null}]}}'
Note that the error is printed to the standard output. This is unexpected because in the app I'm integrating Smartling into, I would check for status and then log resp.errors or raise an exception. That print would be a redundant noise injected into the app normal output (logs and warnings, primarily).
I think you should consider either removing those prints (if those are accidental debug prints) or replacing them with (debug-level?) logging (which I know you're already configured and use in other places)—depending on each case, I believe.
The text was updated successfully, but these errors were encountered:
In multiple places in your SDK, you're using
print
outside the examples:e.g.
api-sdk-python/smartlingApiSdk/HttpClient.py
Lines 95 to 97 in f65d52b
That leads to unexpected results for the users (myself included):
Note that the error is printed to the standard output. This is unexpected because in the app I'm integrating Smartling into, I would check for
status
and then logresp.errors
or raise an exception. That print would be a redundant noise injected into the app normal output (logs and warnings, primarily).I think you should consider either removing those
print
s (if those are accidental debug prints) or replacing them with (debug-level?)logging
(which I know you're already configured and use in other places)—depending on each case, I believe.The text was updated successfully, but these errors were encountered: