Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could --dry-run do deeper validation? #251

Open
pfnsec opened this issue May 11, 2024 · 0 comments
Open

Could --dry-run do deeper validation? #251

pfnsec opened this issue May 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@pfnsec
Copy link

pfnsec commented May 11, 2024

Is your feature request related to a problem? Please describe.
We are running schemachange in CI. Before a merge, we run it with --dry-run, but by design, it doesn't catch basic SQL syntax errors. We'd like to have a CI step that gives us a stronger guarantee of fitness for the migrations staged in a PR.

Describe the solution you'd like
Perhaps a more exhaustive test run of the syntax could be implemented? It could be an intermediate step like schemachange --plan. This would enhance schemachange's utility to us as part of our CI flow.

@pfnsec pfnsec added the enhancement New feature or request label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant