Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vCompat Updater occasionally hits GitHub rate-limit #1

Open
bluelhf opened this issue Oct 2, 2022 · 2 comments
Open

vCompat Updater occasionally hits GitHub rate-limit #1

bluelhf opened this issue Oct 2, 2022 · 2 comments

Comments

@bluelhf
Copy link

bluelhf commented Oct 2, 2022

As seen in this review on LoginPlus:
image

vCompat's updater is fetching data from the GitHub API without authentication, which sometimes causes it to fail to start. To solve this issue, vCompat Updater must either

  1. Use vCompat's own caching server, which caches the results from the GitHub API (optionally with its own token), or
  2. Allow graceful failure if the GitHub API rate limit is reached — an exception should not be thrown.
@Lauriichan
Copy link
Member

Lauriichan commented Aug 21, 2023

Normally it shouldn't just stop working

@Lauriichan
Copy link
Member

I just checkd, if there is an exception when requesting the github version it will still continue if there is an existing version of vCompat already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants