Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding comment about gas #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding comment about gas #26

wants to merge 2 commits into from

Conversation

theochap
Copy link

Description

As specified during the daily, here is a small PR that adds documentation to the sov-rollup-starter in the README.md on gas consumption.

@theochap theochap requested a review from bkolad July 10, 2024 16:01
```

#### Optional: Setup the gas constants for transaction execution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section on gas has useful information but seems out of proportion to the rest of the README (It's as long as the rest of the README put together). Can we pare it down to just...

  • A super bare-bones getting started guide for gas (i.e. set up your account with _ tokens, set your max_fee to _)
  • A pointer to a more full explanation

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants