Duplicated group member requirement records

[SteveSwaringen]

Description

When a SQL group requirement is added to a fundraising group and members have not met the requirement for that fundraising group, they are able to click on a workflow to fulfill that requirement. When a workflow is clicked on (started) another group member requirement is created for that group member.

Actual Behavior

Important Notes:

1. This DOES NOT occur for Manual or Data view Group Requirements. This ONLY occurs for SQL Group Requirements
2. The group requirement does not produce the same behavior when trying to fulfill the requirement internally. For example, if I have a requirement and I click on my internal group member profile, I can see a banner that says the requirement is not met and an option to click on a workflow. If I click on this workflow internally, it does not create another group requirement for me. It only creates a requirement for me if I click the workflow option on the external page after I have made a change to the group requirement.
3. Ways I have triggered the bug. It looks like the bug is happening because of clicking the workflow twice and maybe not anything to do with editing the group requirement itself:
   3.a. Group Member clicks on the group requirement workflow then leaves it. The group requirement is changed internally. Then the Group Member clicks on the Group requirement workflow a second time.
   3.b. Group Requirement is created and is set up on a group. The group requirement is then changed in any way. The Group Member now clicks on the Group Requirement Workflow at least TWICE externally
   3.c. UPDATE: I duplicated the new group requirement and saved it. I did not make any changes to it but it still gave me duplicate group requirement entities for the group member once I clicked the workflow on the external fundraising page more than once
4. This Bug still appears even if at least one person meets the requirement
5. The bug appears regardless of whether the group requirement is a specific group requirement for a group or whether the group requirement is inherited from a group type

Expected Behavior

The group member requirement will not be duplicated.

Steps to Reproduce

Reproduction Steps: Two ways
Method One:

1. Create a group with the Group Type of Fundraising Opportunity.
2. Add yourself (Alisha Admin) into the group
3. Create a test workflow with anything in it.
4. I used one form input action for my tests
5. Add a SQL Group Requirement with any SQL in it that does not involve the group member automatically meeting the requirement and add the above workflow you created to Does Not Meet Requirements Workflow
6. I used: SELECT [Id] FROM [Person]
7. WHERE [Id] IS NULL
8. Go to the external fundraising participant page
   • On Rock Demo and Prealpha: /page/473?GroupId={{ yourGroupId }}&GroupMemberId={{ yourGroupMemberId }}
9. Click on the group requirements workflow
10. Go back to the group requirement on the internal site. Make a change to the group requirement.
11. Refresh the Fundraising participant page and click on the group requirement workflow again
12. Head to the internal group viewer page and clicking on requirements should give you two requirements now for the same group requirement

Method Two:

1. Create a group with the Group Type of Fundraising Opportunity.
2. Add yourself (Alisha Admin) into the group
3. Create a test workflow with anything in it.
4. I used one form input action for my tests
5. Add a SQL Group Requirement with any SQL in it that does not involve the group member automatically meeting the requirement and add the above workflow you created to Does Not Meet Requirements Workflow
6. I used: SELECT [Id] FROM [Person]
7. WHERE [Id] IS NULL
8. Click on the group requirement and make any change to it and save.
9. Go to the external fundraising participant page
   • On Rock Demo and Prealpha: /page/473?GroupId={{ yourGroupId }}&GroupMemberId={{ yourGroupMemberId }}
10. Click on the group requirement workflow. (See that if you check the group viewer page now for the fundraising group, only one requirement will show up)
11. Go back to the fundraising participant page and click a second time on the group requirement workflow
12. Navigate back to the group viewer page and click on group requirements. You should see two requirements for the same group requirement

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

16.6, 17.0

Client Culture Setting

en-US