Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select a search option using keyboard arrows #44

Open
aryabagde opened this issue Dec 4, 2021 · 11 comments
Open

Select a search option using keyboard arrows #44

aryabagde opened this issue Dec 4, 2021 · 11 comments

Comments

@aryabagde
Copy link

When we type something on the search box, we should be able to select the options available using keyboard arrows

@aryabagde
Copy link
Author

Can I work on this issue?

@Sparsh1212
Copy link
Owner

The issue looks genuine to me. Feel free to work on this.

@aryabagde
Copy link
Author

Can you assign it to me and add labels on this issue?

@Sparsh1212
Copy link
Owner

@aryabagde Any update on this?

@iamrahulrnair
Copy link
Contributor

can i work on this?

@iamrahulrnair
Copy link
Contributor

Hey, do I have to comment in the codebase ? what's the procedure? I've spend some time figuring out the type of states without documentation, and also please check is this the intended behaviour?

50561ba4-c75a-4766-ad8e-aaf6fd33fc16.mp4

.

@iamrahulrnair
Copy link
Contributor

guys ,can i get a review on this?

@Sparsh1212
Copy link
Owner

guys ,can i get a review on this?

Looks good to me. You can submit a PR for this.

@aritroCoder
Copy link
Contributor

aritroCoder commented Dec 28, 2021

I have fixed this issue. Please check the video and tell me if I can make a PR on this

2021-12-28.17-07-12.mp4

@Sparsh1212
Copy link
Owner

I have fixed this issue. Please check the video and tell me if I can make a PR on this

2021-12-28.17-07-12.mp4

@aritroCoder Thanks for initiating a fix. But apologies as there already has been a PR open for this issue. It's under review, so it will be unfair to the first initiator. You are most welcome to work on other open issues :)

@aritroCoder
Copy link
Contributor

aritroCoder commented Dec 29, 2021

Ok no problem, I saw the PR thread was inactive for 8 days so thought to post the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants