Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select All via Relationship table Exports Entire Resource #166

Open
3 tasks done
feenx opened this issue Jun 28, 2023 · 0 comments
Open
3 tasks done

Select All via Relationship table Exports Entire Resource #166

feenx opened this issue Jun 28, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@feenx
Copy link

feenx commented Jun 28, 2023

Prerequisites

  • Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
  • Checked that your issue isn't already filed.
  • Checked if no PR was submitted that fixes this problem.

Versions

  • PHP version: 8.1
  • Laravel version: 9.52.8
  • Nova version: 4.24.4
  • Package version: 3.1.48 / 1.3.5

Description

When using the Download Excel action after choosing "Select All" from pagination on a relationship table within a resource. The entire tabled resource is exported instead of just the related records.

For example, a Bank Account is related to it's Bank Transactions. But when using the Download Excel on a table of related Bank Transactions on the Bank Account page, it exports the entire Bank Transactions table. As opposed to only Bank Transactions related to the Bank Account I was viewing within Nova.

Steps to Reproduce

Create Nova install with any Parent/Child model structure where not all children are related to all parents. Visit a parent page, use Download Excel action on children via relationship Table.

Expected behavior:

Only related children resources would be exported by exporting a child resource from it's parent resource detail page.

Actual behavior:

All children resources, across all parent resources are exported.

@patrickbrouwers patrickbrouwers added enhancement New feature or request help wanted Extra attention is needed labels Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants