M365 Builder indexOf error

[tankerkiller125]

Describe the bug
Adding the following to an existing dnscontrol domain file results in an indexOf error.

M365_BUILDER({
    initialDomain: 'example.onmicrosoft.com',
    autodiscover: true,
    dkim: true,
    mx: true,
    skypeForBusiness: true,
    mdm: true
  }),

I've also tried it with only the initialDomain set, and with and without the domainGuid.

The exact error is executing dnsconfig.js: Error: File example.com.js: TypeError: 'indexOf' is not a function

To Reproduce
Steps to reproduce the behavior:

1. Create a dnsconfig.js file that uses require_glob('folder', false)
2. Create the domain file, include the M365_BUILDER function
3. Execute dnscontrol preview
4. See error

Expected behavior
This error shouldn't happen

DNS Provider

• Cloudflare

Additional context
The existing DNS records on the domain have the M365 records, we're just trying to use the M365 Builder instead to clean up the config and make life a little easier. I don't think that's in anyway what's causing a conflict or issue though.

Commenting out the builder and everything works perfectly fine, bring it back though and this error get spit out.

[tlimoncelli]

Can you try this again with the v4.2.0 release? 354063c may have fixed this.

[tlimoncelli]

@juliusrickert I believe you contributed the code. Can you take a look?

(I have a hunch that r should be var r around line 1700 but I'm no Javascript expert!)

[tlimoncelli]

@tankerkiller125
Could you try using the code in this PR? #2724

[tankerkiller125]

This seems to be fixed with the PR, not getting an error, and it published the M365 records successfully.

[tlimoncelli]

Thanks, @tankerkiller125 !

[nikolamilekic]

I get the same error with 4.9.0. It also goes away when I remove the M365 Builder. Same repro steps with one difference: I'm not using require_glob.

[Koopzington]

@nikolamilekic

The example in the docs is wrong.
apparently you need to pass the domain as first argument and the other options as second argument https://github.com/StackExchange/dnscontrol/blob/v4.11.0/pkg/js/helpers.js#L1709

[nikolamilekic]

That fixed it, thanks!

On June 13, 2024, GitHub Notifications ***@***.***> wrote: @nikolamilekic <https://github.com/nikolamilekic> The example in the docs is wrong.  apparently you need to pass the domain as first argument and the other options as second argument <https://github.com/StackExchange/dnscontrol/blob/v4.11.0/pkg/js/helpers.js#L1709>

— Reply to this email directly, view it on GitHub <#2457 (comment)- 2165769432>, or unsubscribe <https://github.com/notifications/unsubscribe- auth/AA6C377AQZBJSOGQL7KZH63ZHGRBBAVCNFSM6AAAAAAZPCO2SGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRVG43DSNBTGI>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[cafferata]

Thanks @Koopzington for the feedback. I asked the author for clarification on the original implementation. See #3008

[nikolamilekic]

Oh, I may have submitted a pull request fixing the examples too quickly then. For reference its #3009