Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNR Provider: Review CI / Docs / Capabilities (add NAPTR, SSHFP) #3235

Conversation

KaiSchwarz-cnic
Copy link
Contributor

@KaiSchwarz-cnic KaiSchwarz-cnic commented Dec 10, 2024

@tlimoncelli I went through all the capabilities and played around with the CentralNic Reseller API. All this is now updated and great that I've been able to identify SSHFP and NAPTR as supported record types.
Finally, I went through the Dev Guide for new Provider Modules and reviewed the missing parts.

  • Reviewed Provider Capabilities
  • Added support for NAPTR record
  • Added support for SSHFP record
  • reviewed documentation
    • cleanup requested providers
    • added CNR to the provider list
  • reviewed reported linting issues (golangci-lint)
  • fixed go releaser regexp

Integration Tests passed:

...
--- PASS: TestDualProviders (4.89s)
=== RUN   TestNameserverDots
No nameservers found
=== RUN   TestNameserverDots/No_trailing_dot_in_nameserver
--- PASS: TestNameserverDots (0.12s)
    --- PASS: TestNameserverDots/No_trailing_dot_in_nameserver (0.00s)
PASS
ok      github.com/StackExchange/dnscontrol/v4/integrationTest  381.239s

@AsifNawaz-cnic AsifNawaz-cnic force-pushed the cnr-review-capabilities branch from a664910 to f06d503 Compare December 12, 2024 11:28
@AsifNawaz-cnic AsifNawaz-cnic force-pushed the cnr-review-capabilities branch from f06d503 to cc25e01 Compare December 12, 2024 11:29
@tlimoncelli
Copy link
Contributor

Please rebase

@tlimoncelli
Copy link
Contributor

(It looks like the only file that has a merge conflict is generated. A quick go generate ./... should (?) fix it.)

@tlimoncelli
Copy link
Contributor

Sorry for all the emails. I was trying to construct a "suggested change" that would enable the merge, but I forgot that wouldn't work due to permissions issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants