Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Search term & optic disappear when using back button #125

Open
rrmn opened this issue Feb 5, 2024 · 2 comments
Open

Bug: Search term & optic disappear when using back button #125

rrmn opened this issue Feb 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@rrmn
Copy link

rrmn commented Feb 5, 2024

  1. Search for something (e.g. "Land Cruiser 80)
  2. Optional: add optic
  3. Click on first result
  4. Return to search results
  5. Search term (& optic) has (have) disappeared

edit: iOS 17 + Firefox

@mikkeldenker mikkeldenker added the bug Something isn't working label Feb 5, 2024
@mikkeldenker
Copy link
Member

Interesting. It works for me in firefox and chrome, but I am able to reproduce this bug in safari.
Thanks for the report!

@lamemakes
Copy link
Contributor

This seems to be related to the autocomplete="off" on the search field. I've seen indication that this can effect the re-filling of the forms on selecting the Previous Page button. On Safari, when I swapped off for on it seemed to properly refill the search field. I inspected all the bfcache too and that looked right.

Going to keep digging - DuckDuckGo uses the autocomplete="off" in it's search bar but doesn't have the same issue so it's definitely fixable. I also couldn't recreate the issues with the optic - that seemed to refill out of the box not matter what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants