Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: When file being edited has unsaved changes, ask for confirmation before closing the edit dialog #3697

Open
awa-xima opened this issue Jan 17, 2025 · 0 comments · May be fixed by #3698
Open

Feature: When file being edited has unsaved changes, ask for confirmation before closing the edit dialog #3697

awa-xima opened this issue Jan 17, 2025 · 0 comments · May be fixed by #3698

Comments

@awa-xima
Copy link
Contributor

ElFinder includes many editors for editing files directly within the file explorer. When a file has unsaved changes and the user closes the edit dialog, ElFinder currently first closes the dialog, then asks the user whether they want to save their changes:

confirmAfterClose.webm

We received feedback by our users that this is unintuitive. Instead, ElFinder should keep the dialog open and ask the user whether they want to cancel the operation (keeps the edit dialog open), discard their changes, or save their changes. This is also the behavior of many other text editors. To illustrate, ElFinder should behave like this:

confirmBeforeClose.webm

I'll open a PR for this.
blutorange pushed a commit to blutorange/elFinder that referenced this issue Jan 17, 2025
@awa-xima
Add option commandsOptions.edit.confirmUnsavedBeforeClose
d5674b9 
Defaults to false. When set to true, the edit dialog asks the
user for confirmation first when they have unsaved changes and
attempt to close the dialog. The user can either cancel the operation,
keeping the dialog open, discard their changes, or save their changes.

Implements Studio-42#3697
@blutorange blutorange linked a pull request Jan 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implements #3697, ask before closing edit dialog on unsaved changes blutorange/elFinder
1 participant
@awa-xima