-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code lenses look weird when syntax errors are reported #1123
Labels
Comments
This is partly blocked by #1344, as we get 0 parse diags set now, so we can't tell if the module is stale or not. |
I think the title is referring to Code Lenses rather than actions? |
Indeed! Fixed. |
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this issue
Jan 20, 2025
Fixes StyraInc#1123 Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this issue
Jan 20, 2025
Fixes StyraInc#1123 Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We can't evaluate or debug files with syntax errors, but it looks like we keep sending these from the server in that case, presumably from the last known good state, which sometimes makes them appear in weird locations. We should simply not return anything in this case.
Perhaps later on we can have those actions located before any syntax errors in the file remain and when clicked help the user understand more about the error... but it's likely better to show syntax errors in-lined like linter issues anyway. So let's just hide the actions for now.
The text was updated successfully, but these errors were encountered: