Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

globStream support #24

Open
benmccann opened this issue Aug 25, 2024 · 5 comments
Open

globStream support #24

benmccann opened this issue Aug 25, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@benmccann
Copy link
Contributor

I saw this requested in webpro-nl/knip#768
@SuperchupuDev
Copy link
Owner

SuperchupuDev commented Aug 25, 2024 •
edited
Loading

it is possible to add (fdir exposes an option for it), but i'm not sure about adding extra options just because they could be useful for some (that's how libraries get bloated, right?). i feel like the proper fix would be to add globStream

@benmccann
Copy link
Contributor Author

Yeah, I think if you click through to see how it was originally done it was with globStream

@SuperchupuDev SuperchupuDev added the enhancement New feature or request label Aug 26, 2024
@benmccann
Copy link
Contributor Author

Immich is another project that we can switch over to tinyglobby once we have globStream

@benmccann benmccann changed the title A way to stop searching when first match is found globStream support Oct 7, 2024
@benmccann benmccann mentioned this issue Oct 7, 2024
Closed
@etnoy
Copy link

etnoy commented Oct 7, 2024

Seems like fdir is lacking any such support, however

@benmccann
Copy link
Contributor Author

Here's the issue in fdir that this depends on: thecodrr/fdir#40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@etnoy @benmccann @SuperchupuDev