tinyglobby can hang on invalid fast-glob backslash usage

[userquin]

Check vuejs/vitepress#4357

[SuperchupuDev]

i'm on windows and absolute patterns should work, can you provide a minimal repro? whatever it is if it's perf related #69 will probably solve it

[userquin]

clone VP (VitePress) repo then pnpm install && pnpm build

[SuperchupuDev]

it's using an absolute path with \s, which normally shouldn't be used in glob patterns in neither fast-glob or tinyglobby (https://github.com/mrmlnc/fast-glob#pattern-syntax). will investigate how fast-glob handles them when the pattern is absolute though

[userquin]

FYI: I added fast-glob in VP repo pnpm add -D fast-glob -w changing the rollup.config.ts import and usage and it works:

// foo.js => node ./foo.js
import { resolve, normalize } from 'node:path'
import { fileURLToPath } from 'node:url'
import { globSync } from 'tinyglobby'

const ROOT = fileURLToPath(import.meta.url)
const r = (p) => normalize(resolve(ROOT, '..', p))

console.log(r('src/node/worker_*.ts'))
console.log(
  globSync('src/node/worker_*.ts', {
    cwd: r('.'),
    onlyFiles: true,
    expandDirectories: false
  })
)
console.log('RUNNING')

[userquin]

https://github.com/mrmlnc/fast-glob?tab=readme-ov-file#how-to-write-patterns-on-windows

fast-glob handles that, but doesn't recommend

Using simple replacement works:

[userquin]

@SuperchupuDev https://github.com/mrmlnc/fast-glob/blob/da648078ae87bce81fcd42e64d5b2b1360c47b09/src/utils/path.ts#L57

[SuperchupuDev]

will try to make it as consistent to fast-glob as possible

[Torathion]

Any news on this? This is probably the biggest reason that prevents many tools from switch from fast-glob to tinyglobby.

[SuperchupuDev]

is it? thought it wasn't a priority since the issue author's linked repo no longer has the problem. can take a deeper look into it for the next release that i want to release ASAP

[Torathion]

From what I've gathered: The windows glob issues are very important. OP came from vitepress having this issue and remix and analog also referring to this issue. I wanted to make a PR in npm-check-updates and came across the same issue as a dozen tests started to fail after switching from fast-glob to tinyglobby.

[Sytten]

I would also say yes this is an issue, we use tsup to build plugins in our ecosystem and I got a report from a user that the build process was hanging on windows. It does look like it is related to tinyglobby.

[SuperchupuDev]

sorry to keep y'all waiting, the next release is currently being blocked by some perf implementation (currently broken on main) that i've been trying to figure out for a while. once that's solved i'll fix this and release a new version

[SuperchupuDev]

the perf implementation has been merged! so i'm working on this right now, but i can't seem to find a single pattern with \ as separators that make fast-glob work, on either windows or linux. @Torathion @userquin can y'all share a minimal reproduction of a case in which fast-glob returns results correctly like that? to then change tinyglobby so that it matches fast-glob's functionality

[Torathion]

Unfortunately I can't help you with this as I'm not very familiar with globs. I only found out about it when the tests in NCU suddenly failed after using it as a drop-in replacement.

But I see that you only have tests using /, while you don't have any tests using \\ alone. Maybe adding these tests would help to establish tinyglobby as drop-in replacement for fast-glob.

[userquin]

@SuperchupuDev here small reproduction using both: https://github.com/userquin/tinyglobby-issue-72

[SuperchupuDev]

@userquin fg.mjs doesn't seem to return anything in your repro. is there any case in which fast-glob returns something with windows paths as likely expected, or is the issue that tinyglobby doesn't return []? i thought the expected thing was support for those patterns (i don't have windows, screenshot is from a friend, sorry for the quality)

[userquin]

Yeah, fg.mjs doesn't hang while tg.mjs does (the original issue)

https://github.com/mrmlnc/fast-glob?tab=readme-ov-file#how-to-write-patterns-on-windows

[SuperchupuDev]

okay, so as far as i understand the problem you all are having is that that invalid fast-glob usage hangs, but it's invalid fg usage regardless. is that right?

[SuperchupuDev]

in theory the new optimizer i merged a few days ago should make this not hang anymore (in fact we tried and it doesn't hang while it did on 0.2.10), but it still creates an odd internal state regardless

[SuperchupuDev]

@userquin tinyglobby 0.2.11 is out which should fix the perf problems thanks to new optimizations introduced. can you tell me if it still hangs? locally reproducing it doesn't seem to hang anymore, at least on a friend's computer

[userquin]

@SuperchupuDev now it works: