Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Choos plan button text is not visible in the dark mode #59

Merged
merged 4 commits into from
Oct 27, 2024

Conversation

zaheer-Khan3260
Copy link
Contributor

fix: Choos plan button text is not visible in the dark mode

Copy link

vercel bot commented Oct 27, 2024

@zaheer-Khan3260 is attempting to deploy a commit to the devsuraj Team on Vercel.

A member of the Team first needs to authorize it.

@zaheer-Khan3260
Copy link
Contributor Author

here is the screenshot.
Screenshot 2024-10-27 131818

@zaheer-Khan3260
Copy link
Contributor Author

@Suraj-kumar00 merge this pull request.

@Suraj-kumar00 Suraj-kumar00 self-requested a review October 27, 2024 07:52
@Suraj-kumar00
Copy link
Owner

@Suraj-kumar00 merge this pull request.

Star this repository 🌟

@Suraj-kumar00
Copy link
Owner

Hey @zaheer-Khan3260 isn't it will look good if you set the color also to these two buttons as first one and only the hover effect you can set it to good looking color same as the theme. And yeah please share the preview.

@zaheer-Khan3260
Copy link
Contributor Author

@Suraj-kumar00 I fix the #53 . I'll open a pull request in that pull request i implement this also. is it sound good?

@Suraj-kumar00
Copy link
Owner

@Suraj-kumar00 I fix the #53 . I'll open a pull request in that pull request i implement this also. is it sound good?

I have suggested you the changes above.
Please fo that and show me the preview.

And if you like the project please do consider to give the repo a star 🌟

@zaheer-Khan3260
Copy link
Contributor Author

zaheer-Khan3260 commented Oct 27, 2024

@Suraj-kumar00 yeah i add the color based on the theme and add hover effect also here is the preview.
before hover:
Screenshot 2024-10-27 142315

after hover:
Screenshot 2024-10-27 142327

i also fix issue #53 i share that preview also look at it.

Dark mode:
Screenshot 2024-10-27 142559

light mode:
Screenshot 2024-10-27 142628

@Suraj-kumar00 Suraj-kumar00 added hacktoberfest Hacktoberfest 2024 event project Level 2 GSSoC project Level 2 gssoc-ext GirlScript Summer of Code extended project labels Oct 27, 2024
@Suraj-kumar00
Copy link
Owner

Hi @zaheer-Khan3260 thanks for the contribution, and please don't forget to give the repo a star 🌟

@Suraj-kumar00 Suraj-kumar00 merged commit 6302eb6 into Suraj-kumar00:main Oct 27, 2024
1 of 2 checks passed
@Suraj-kumar00
Copy link
Owner

Hi @zaheer-Khan3260, can you star the repo ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GirlScript Summer of Code extended project hacktoberfest Hacktoberfest 2024 event project Level 2 GSSoC project Level 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants