Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArbRewarder: max_delay does not restrict transaction execution time #369

Open
ItsNickBarry opened this issue Dec 17, 2019 · 0 comments
Open

Comments

@ItsNickBarry
Copy link

uint tokens_bought = uniswapExchange.ethToTokenSwapInput.value(eth_to_convert)(min_seth_bought, now + max_delay);

Because now is referenced within the ArbRewarder contract, its value will be set when the transaction is included in a block. And because ethToTokenSwapInput is called within the same transaction, it is always executed within the same block. Therefore, the addition of max_delay does nothing to restrict the actual execution time of the transaction.

Please correct me if I am mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant