Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove public accessor on messageSender from Proxyable #597

Closed
wants to merge 1 commit into from
Closed

remove public accessor on messageSender from Proxyable #597

wants to merge 1 commit into from

Conversation

dev1644
Copy link

@dev1644 dev1644 commented Jul 15, 2020

Resolves #580

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #597 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          44       44           
  Lines        2712     2712           
  Branches      378      378           
=======================================
  Hits         2697     2697           
  Misses         15       15
Impacted Files Coverage Δ
contracts/Proxyable.sol 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb64c6...fcc3f39. Read the comment docs.

zyzek
zyzek approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@zyzek zyzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I suppose this won't be portable backwards to the existing proxies, but will benefit new synths etc.

@jjgonecrypto
Copy link
Contributor

Sorry @dev1644 - even though this is an open issue, it isn't for general consumption. These kinds of changes require planning on our end and testing changes (for legacy support).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyzek zyzek zyzek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove public accessor on Proxyable.messageSender
3 participants
@dev1644 @jjgonecrypto @zyzek