Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate selfDestructBeneficiary from SelfDestructible #581

Open
hav-noms opened this issue Jul 2, 2020 · 2 comments
Open

Deprecate selfDestructBeneficiary from SelfDestructible #581

hav-noms opened this issue Jul 2, 2020 · 2 comments
Labels
enhancement good first issue

Comments

@hav-noms
Copy link
Contributor

hav-noms commented Jul 2, 2020

The only Synthetix contract that holds ETH is EtherColalteral. So none of them need selfDestructBeneficiary.
EtherColalteral does not implement SelfDestructible to give peace of mind to ETH depositors that the owner wont just SelfDestruct the contract and the selfDestructBeneficiary taking all their ETH.
@dev1644
Copy link

dev1644 commented Jul 16, 2020

Does this mean the removal of SelfDestructible contract?

@pratokko
Copy link

how did you solve the issue ? removing SelfDestructable instances from all the contracts for good experiences like @dev1644 mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hav-noms @dev1644 @pratokko