Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added transferOwnership functionality in Owned contract #596

Conversation

dev1644
Copy link

@dev1644 dev1644 commented Jul 15, 2020

Resolves #582

@jjgonecrypto
Copy link
Contributor

@dev1644 Please remove the lockfile change from this PR.

@dev1644 dev1644 force-pushed the feature/add-transferOwnership-functionality-in-Owned-contract branch from 7b30424 to 4e4ef78 Compare July 16, 2020 04:29
@dev1644
Copy link
Author

dev1644 commented Jul 16, 2020

Done @justinjmoses , Removed lock-file but can't run coverage as Heap out of memory error popping up. Root cause of the error is coming from Node runtime I searched for some solutions -:

  • export NODE_OPTIONS=--max_old_space_size=4096, increasing maximum memory available at the run time I was able to run the coverage.

  • buidler --max-memory 4096 coverage --network coverage, I also search through Builder's issues and found out this. I tried to use this by modifying coverage npm script to "coverage": "buidler --max-memory 4096 coverage --network coverage", but it was still breaking.

I also monitor the node runtime service executes after starting coverage tests, I noticed at the time compilation of coverage contracts the runtime was consuming 2.8 GB of memory, Default memory cap of node runtime is ~1.8 GB, so that might be causing the problem.

@zyzek
Copy link
Contributor

zyzek commented Jul 21, 2020

Node is allocated more memory for coverage now, so if you merge from develop this should be resolved.

"coverage": "NODE_OPTIONS=\"--max-old-space-size=4096\" buidler coverage --network coverage",

@jjgonecrypto
Copy link
Contributor

Thanks @dev1644 however we need to discuss this issue more thoroughly before accepting any fixes to it (please see my comment on the issue). I am closing this for now but we can reopen in the future if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Owned.sol to include transferOwnership
3 participants