New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depot depositSynth() to use transferFromAndSettle() #588

Open

hav-noms opened this issue Jul 12, 2020 · 0 comments

Labels

enhancement good first issue

Contributor

hav-noms commented Jul 12, 2020

Internal contracts to Synthetix should implement auto settlement.

https://dashboard.tenderly.co/synthetix/mainnet/tx/main/0x6029ab942caf8ec1619539a78d41a26e91879210419801eb4a7c2ad30abddcbb?utm_campaign=alert_notification&utm_content=transaction_url&utm_medium=slack&utm_source=alert_notification

The impact would be the amount deposited wont be as accepted so we need to show the user there is a settlement.

Mintr to show deposit synths settlement
Update the amount to deposit less the settlement

hav-noms added enhancement good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment